Re: [PATCH] git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED

2015-02-06 Thread Eric Sunshine
On Fri, Feb 6, 2015 at 3:43 PM, Kyle J. McKay wrote: > On Feb 6, 2015, at 12:05, Junio C Hamano wrote: >> "Kyle J. McKay" writes: >>> So I think it needs to stay #define'd to nothing to be safe in case >>> anything later on ends up including stuff that uses it. >> >> Doesn't the fact that your te

Re: [PATCH] git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED

2015-02-06 Thread Kyle J. McKay
On Feb 6, 2015, at 12:05, Junio C Hamano wrote: "Kyle J. McKay" writes: Actually I just tested it. If we #undef it we could end up producing these: error: syntax error before DEPRECATED_ATTRIBUTE So I think it needs to stay #define'd to nothing to be safe in case anything later on ends u

Re: [PATCH] git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED

2015-02-06 Thread Junio C Hamano
"Kyle J. McKay" writes: > Actually I just tested it. If we #undef it we could end up producing > these: > >error: syntax error before DEPRECATED_ATTRIBUTE > > So I think it needs to stay #define'd to nothing to be safe in case > anything later on ends up including stuff that uses it. Do

Re: [PATCH] git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED

2015-02-06 Thread Kyle J. McKay
On Feb 6, 2015, at 02:00, Eric Sunshine wrote: On Fri, Feb 6, 2015 at 4:35 AM, Kyle J. McKay wrote: #ifndef NO_OPENSSL +#ifdef __APPLE__ #define __AVAILABILITY_MACROS_USES_AVAILABILITY 0 -#define MAC_OS_X_VERSION_MIN_REQUIRED MAC_OS_X_VERSION_10_6 +#include +#undef DEPRECATED_ATTRIBUTE +#defi

Re: [PATCH] git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED

2015-02-06 Thread Eric Sunshine
On Fri, Feb 6, 2015 at 4:35 AM, Kyle J. McKay wrote: > MAC_OS_X_VERSION_MIN_REQUIRED may be defined by the builder to a > specific version in order to produce compatible binaries for a > particular system. Blindly defining it to MAC_OS_X_VERSION_10_6 > is bad. > > Additionally MAC_OS_X_VERSION_10

[PATCH] git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED

2015-02-06 Thread Kyle J. McKay
MAC_OS_X_VERSION_MIN_REQUIRED may be defined by the builder to a specific version in order to produce compatible binaries for a particular system. Blindly defining it to MAC_OS_X_VERSION_10_6 is bad. Additionally MAC_OS_X_VERSION_10_6 will not be defined on older systems and should AvailabilityMa