Re: [PATCH] git-check-ignore.txt: Clarify exit codes

2014-12-11 Thread Florian Hassanen
> It smells like you spotted a bug in the behaviour, not a bug in the > documentation, at least to me. At first I thought so as well :-) I even prepared a patch, just to find out, that existing tests specifically test for this "unintuitive" behavior. Then I read the docs in more detail and found

Re: [PATCH] git-check-ignore.txt: Clarify exit codes

2014-12-11 Thread Junio C Hamano
Florian Hassanen writes: > Maybe your global ignore file gets in the way? No, as I do not have one. > is one of a.o and vendor.o already in your index? Bingo. I did "git add ." to see if the .gitignore file is doing the right thing before running that demonstration. It smells like you spotte

Re: [PATCH] git-check-ignore.txt: Clarify exit codes

2014-12-11 Thread Florian Hassanen
>> check-ignore disregards whether a path is matched by a >> positive or negative pattern. Thus for a file that is _not_ >> ignored, but is captured by negative pattern in .gitignore, >> the exit code is 0. The docs suggested otherwise. > > I am not sure that is the actual behaviour of the command.

Re: [PATCH] git-check-ignore.txt: Clarify exit codes

2014-12-11 Thread Junio C Hamano
Florian Hassanen writes: > check-ignore disregards whether a path is matched by a > positive or negative pattern. Thus for a file that is _not_ > ignored, but is captured by negative pattern in .gitignore, > the exit code is 0. The docs suggested otherwise. I am not sure that is the actual behav

[PATCH] git-check-ignore.txt: Clarify exit codes

2014-12-11 Thread Florian Hassanen
check-ignore disregards whether a path is matched by a positive or negative pattern. Thus for a file that is _not_ ignored, but is captured by negative pattern in .gitignore, the exit code is 0. The docs suggested otherwise. Clarify docs to explain that only the match matters, not whether the path