Re: [PATCH] git-archive: accepts --owner --group aslike GNU tar.

2017-12-29 Thread suzuki toshiya
Dear Junio, Ævar Thank you very much for your reviews, in spite of my many overlooking of the requirements written in the documents. To classify various cases, I modified my patch heavily. It would be posted soon. I found that some Python scripts are included in the git repository, but nothing

Re: [PATCH] git-archive: accepts --owner --group aslike GNU tar.

2017-12-28 Thread Junio C Hamano
suzuki toshiya writes: > Current tar output by git-archive has always root:root. Thanks for a patch. On top of Ævar's comments... > ... > * t/t5005-archive-uid-gid.sh: a test script comparing > uid, gid, uname, gname between the options and > generated tar file. > --- Before the "---" lin

Re: [PATCH] git-archive: accepts --owner --group aslike GNU tar.

2017-12-28 Thread Ævar Arnfjörð Bjarmason
On Thu, Dec 28 2017, suzuki toshiya jotted: Thanks for working on this Just a quick review from skimming this, haven't actually applied + run this: > git-archive: accepts --owner --group aslike GNU tar. Make this: git-archive: accept --owner and --group like GNU tar I.e. imperative voice,

[PATCH] git-archive: accepts --owner --group aslike GNU tar.

2017-12-28 Thread suzuki toshiya
Current tar output by git-archive has always root:root. To generate tar output with non-root owner/group, the options like GNU tar are added. * archive.h: add members 'uid', 'gid', 'uname', 'gname' to struct archiver_args. * archive.c: add functions to reflect the operands of '--owner' and '-