On Wed, Mar 19, 2014 at 5:04 AM, Othman Darraz wrote:
> 2014-03-19 0:12 GMT+01:00 Eric Sunshine :
>> On Tue, Mar 18, 2014 at 7:09 PM, Eric Sunshine
>> wrote:
>>
>> >> diff --git a/fsck.c b/fsck.c
>> >> index 64bf279..5eae856 100644
>> >> --- a/fsck.c
>> >> +++ b/fsck.c
>> >> @@ -290,7 +290,7 @@ s
On 03/19/2014 12:09 AM, Eric Sunshine wrote:
> Thanks for the submission. Comments below to give you a taste of the
> Git review process...
>
> On Tue, Mar 18, 2014 at 6:41 PM, Othman Darraz wrote:
>> use of starts_with() instead of memcmp()
>>
>> use of skip_prefix instead of memcmp() and strlen
On Tue, Mar 18, 2014 at 7:09 PM, Eric Sunshine wrote:
>> diff --git a/fsck.c b/fsck.c
>> index 64bf279..5eae856 100644
>> --- a/fsck.c
>> +++ b/fsck.c
>> @@ -290,7 +290,7 @@ static int fsck_commit(struct commit *commit, fsck_error
>> error_func)
>> int parents = 0;
>> int err;
>>
Thanks for the submission. Comments below to give you a taste of the
Git review process...
On Tue, Mar 18, 2014 at 6:41 PM, Othman Darraz wrote:
> use of starts_with() instead of memcmp()
>
> use of skip_prefix instead of memcmp() and strlen()
Write proper sentences to explain and justify the ch
use of starts_with() instead of memcmp()
use of skip_prefix instead of memcmp() and strlen()
Signed-off-by: Othman Darraz
---
I am planning to apply to GSOC 214
fsck.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fsck.c b/fsck.c
index 64bf279..5eae856 100644
---
5 matches
Mail list logo
