Re: [PATCH] fsck: return non-zero status on missing ref tips

2014-09-15 Thread Michael Haggerty
On 09/12/2014 06:29 AM, Jeff King wrote: > [+cc mhagger for packed-refs wisdom] > > On Thu, Sep 11, 2014 at 11:38:30PM -0400, Jeff King wrote: > >> Fsck tries hard to detect missing objects, and will complain >> (and exit non-zero) about any inter-object links that are >> missing. However, it wil

Re: [PATCH] fsck: return non-zero status on missing ref tips

2014-09-15 Thread Michael Haggerty
On 09/12/2014 06:58 AM, Junio C Hamano wrote: > On Thu, Sep 11, 2014 at 9:29 PM, Jeff King wrote: >> [+cc mhagger for packed-refs wisdom] >> >> If we only have a packed copy of "refs/heads/master" and it is broken, >> then deleting any _other_ unrelated ref will cause refs/heads/master to >> be dr

Re: [PATCH] fsck: return non-zero status on missing ref tips

2014-09-11 Thread Jeff King
On Thu, Sep 11, 2014 at 09:58:45PM -0700, Junio C Hamano wrote: > On Thu, Sep 11, 2014 at 9:29 PM, Jeff King wrote: > > [+cc mhagger for packed-refs wisdom] > > > > If we only have a packed copy of "refs/heads/master" and it is broken, > > then deleting any _other_ unrelated ref will cause refs/h

Re: [PATCH] fsck: return non-zero status on missing ref tips

2014-09-11 Thread Junio C Hamano
On Thu, Sep 11, 2014 at 9:29 PM, Jeff King wrote: > [+cc mhagger for packed-refs wisdom] > > If we only have a packed copy of "refs/heads/master" and it is broken, > then deleting any _other_ unrelated ref will cause refs/heads/master to > be dropped from the packed-refs file entirely. We get an e

Re: [PATCH] fsck: return non-zero status on missing ref tips

2014-09-11 Thread Jeff King
On Fri, Sep 12, 2014 at 12:29:39AM -0400, Jeff King wrote: > Dropping curate_packed_ref_fn (as below) fixes the test above. And > miraculously does not even seem to conflict with ref patches in pu. :) Of course I spoke too soon. The patch I sent is actually based on pu. It is easy to make the equ

Re: [PATCH] fsck: return non-zero status on missing ref tips

2014-09-11 Thread Jeff King
[+cc mhagger for packed-refs wisdom] On Thu, Sep 11, 2014 at 11:38:30PM -0400, Jeff King wrote: > Fsck tries hard to detect missing objects, and will complain > (and exit non-zero) about any inter-object links that are > missing. However, it will not exit non-zero for any missing > ref tips, mean

[PATCH] fsck: return non-zero status on missing ref tips

2014-09-11 Thread Jeff King
> On Tue, Sep 09, 2014 at 03:03:33PM -0700, Junio C Hamano wrote: > > > Upon finding a corrupt loose object, we forgot to note the error to > > signal it with the exit status of the entire process. > > > > [jc: adjusted t1450 and added another test] > > > > Signed-off-by: Junio C Hamano > > ---