Re: [PATCH] fsck: exit with non-zero status upon error from fsck_obj()

2014-09-09 Thread Jonathan Nieder
Junio C Hamano wrote: > By the way, Jonathan, with dbedf8bf (t1450 (fsck): remove dangling > objects, 2010-09-06) you added a 'test_might_fail git fsck' to the > 1450 test that catches an object corruption. Do you remember if > there was some flakiness in this test that necessitated it, or is it

Re: [PATCH] fsck: exit with non-zero status upon error from fsck_obj()

2014-09-09 Thread Junio C Hamano
Junio C Hamano writes: > From: Jeff King > Date: Fri, 29 Aug 2014 16:31:46 -0400 > > Upon finding a corrupt loose object, we forgot to note the error to > signal it with the exit status of the entire process. > > [jc: adjusted t1450 and added another test] Spoke too soon. If found another inst

Re: [PATCH] fsck: exit with non-zero status upon error from fsck_obj()

2014-09-09 Thread Jeff King
On Tue, Sep 09, 2014 at 03:03:33PM -0700, Junio C Hamano wrote: > From: Jeff King > Date: Fri, 29 Aug 2014 16:31:46 -0400 > > Upon finding a corrupt loose object, we forgot to note the error to > signal it with the exit status of the entire process. > > [jc: adjusted t1450 and added another tes

[PATCH] fsck: exit with non-zero status upon error from fsck_obj()

2014-09-09 Thread Junio C Hamano
From: Jeff King Date: Fri, 29 Aug 2014 16:31:46 -0400 Upon finding a corrupt loose object, we forgot to note the error to signal it with the exit status of the entire process. [jc: adjusted t1450 and added another test] Signed-off-by: Junio C Hamano --- * I think your fix is a right one that