Re: [PATCH] format-patch: set diffstat width to 70 instead of default 80

2018-01-22 Thread Duy Nguyen
On Tue, Jan 23, 2018 at 6:52 AM, Jeff King wrote: > On Mon, Jan 22, 2018 at 07:31:54PM +0700, Nguyễn Thái Ngọc Duy wrote: > >> Patches or cover letters generated by format-patch are meant to be >> exchanged as emails, most of the time. And since it's generally agreed >> that text in mails should b

Re: [PATCH] format-patch: set diffstat width to 70 instead of default 80

2018-01-22 Thread Jeff King
On Tue, Jan 23, 2018 at 01:10:43AM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Jan 22 2018, Jeff King jotted: > > > On Mon, Jan 22, 2018 at 07:31:54PM +0700, Nguyễn Thái Ngọc Duy wrote: > >> + opts.diffopt.stat_width = 70; > >> > >>diff_setup_done(&opts); > > > > I wondered how this s

Re: [PATCH] format-patch: set diffstat width to 70 instead of default 80

2018-01-22 Thread Ævar Arnfjörð Bjarmason
On Mon, Jan 22 2018, Jeff King jotted: > On Mon, Jan 22, 2018 at 07:31:54PM +0700, Nguyễn Thái Ngọc Duy wrote: >> +opts.diffopt.stat_width = 70; >> >> diff_setup_done(&opts); > > I wondered how this should interact with any config, but I don't think > you can actually configure the stat-

Re: [PATCH] format-patch: set diffstat width to 70 instead of default 80

2018-01-22 Thread Ævar Arnfjörð Bjarmason
On Mon, Jan 22 2018, Nguyễn Thái Ngọc Duy jotted: > diff --git a/builtin/log.c b/builtin/log.c > index 14fdf39165..6be79656c5 100644 > --- a/builtin/log.c > +++ b/builtin/log.c > @@ -1061,6 +1061,7 @@ static void make_cover_letter(struct rev_info *rev, int > use_stdout, > > memcpy(&opts,

Re: [PATCH] format-patch: set diffstat width to 70 instead of default 80

2018-01-22 Thread Jeff King
On Mon, Jan 22, 2018 at 07:31:54PM +0700, Nguyễn Thái Ngọc Duy wrote: > Patches or cover letters generated by format-patch are meant to be > exchanged as emails, most of the time. And since it's generally agreed > that text in mails should be wrapped around 70 columns or so, make sure > these diff

Re: [PATCH] format-patch: set diffstat width to 70 instead of default 80

2018-01-22 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Patches or cover letters generated by format-patch are meant to be > exchanged as emails, most of the time. And since it's generally agreed > that text in mails should be wrapped around 70 columns or so, make sure > these diffstat follow the convention. > > I notic

[PATCH] format-patch: set diffstat width to 70 instead of default 80

2018-01-22 Thread Nguyễn Thái Ngọc Duy
Patches or cover letters generated by format-patch are meant to be exchanged as emails, most of the time. And since it's generally agreed that text in mails should be wrapped around 70 columns or so, make sure these diffstat follow the convention. I noticed this when I quoted a diffstat line [1].