Re: [PATCH] format-patch: print format-patch usage if there are no arguments

2015-01-13 Thread Junio C Hamano
Jeff King writes: > So that is perhaps not asking for the feature (I am already happy with > my homegrown wrapper), but is maybe an endorsement of it. :) OK. A patch to add this should be reasonably clean and trivial, I would guess. -- To unsubscribe from this list: send the line "unsubscribe g

Re: [PATCH] format-patch: print format-patch usage if there are no arguments

2015-01-13 Thread Stefan Beller
On Tue, Jan 13, 2015 at 2:45 PM, Jeff King wrote: > On Tue, Jan 13, 2015 at 02:28:13PM -0800, Junio C Hamano wrote: > >> On the other hand, "I am forked from building on this one" done with >> "checkout -t" is an explicit mark the user leaves, so it would serve >> as a better hint to base the defa

Re: [PATCH] format-patch: print format-patch usage if there are no arguments

2015-01-13 Thread Jeff King
On Tue, Jan 13, 2015 at 02:28:13PM -0800, Junio C Hamano wrote: > On the other hand, "I am forked from building on this one" done with > "checkout -t" is an explicit mark the user leaves, so it would serve > as a better hint to base the default heuristics on, I think. > > But nobody is asking for

Re: [PATCH] format-patch: print format-patch usage if there are no arguments

2015-01-13 Thread Junio C Hamano
Stefan Beller writes: > Another idea would be to take the first commit which is pointed to by > another branch as the first commit in the commit range. Trying to figure out what happened from the topology of the history is certainly attractive proposition, but I suspect that it would be too frag

Re: [PATCH] format-patch: print format-patch usage if there are no arguments

2015-01-13 Thread Stefan Beller
On Tue, Jan 13, 2015 at 11:17 AM, Junio C Hamano wrote: > Alexander Kuleshov writes: > >> 2015-01-14 0:43 GMT+06:00 Junio C Hamano : >>> Why? >> >> As some commands does it when they are executed without arguments, >> like git config, git blame and etc... > > For format-patch, I think the current

Re: [PATCH] format-patch: print format-patch usage if there are no arguments

2015-01-13 Thread Junio C Hamano
Alexander Kuleshov writes: > 2015-01-14 0:43 GMT+06:00 Junio C Hamano : >> Why? > > As some commands does it when they are executed without arguments, > like git config, git blame and etc... For format-patch, I think the current behaviour is more of the lack of implementation of the obvious defa

Re: [PATCH] format-patch: print format-patch usage if there are no arguments

2015-01-13 Thread Alexander Kuleshov
Hello Junio, As some commands does it when they are executed without arguments, like git config, git blame and etc... 2015-01-14 0:43 GMT+06:00 Junio C Hamano : > Why? -- _ 0xAX -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message

Re: [PATCH] format-patch: print format-patch usage if there are no arguments

2015-01-13 Thread Junio C Hamano
Why? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] format-patch: print format-patch usage if there are no arguments

2015-01-13 Thread Alexander Kuleshov
Signed-off-by: Alexander Kuleshov --- builtin/log.c | 4 1 file changed, 4 insertions(+) diff --git a/builtin/log.c b/builtin/log.c index ad3cfd8..4431b50 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1246,6 +1246,10 @@ int cmd_format_patch(int argc, const char **argv, const char *pre