Re: [PATCH] fmt-merge-msg: plug small leak of commit buffer

Jeff King writes: > I note that record_person does not seem to care about the commit at all, > so an alternative fix would be: > > diff --git a/builtin/fmt-merge-msg.c b/builtin/fmt-merge-msg.c > index 1d962dc..9f0e608 100644 > --- a/builtin/fmt-merge-msg.c > +++ b/builtin/fmt-merge-msg.c > @@ -2

Re: [PATCH] fmt-merge-msg: plug small leak of commit buffer

On Wed, Apr 15, 2015 at 02:30:17PM -0700, Junio C Hamano wrote: > I spoke too soon. There are two error-exit paths in this function. > > -- >8 -- > A broken or badly formatted commit might not record author or > committer lines or we may not find a valid name on them. The > function record_pers

Re: [PATCH] fmt-merge-msg: plug small leak of commit buffer

Junio C Hamano writes: > A broken or badly formatted commit might not record author or > committer lines; the function record_person() returned after > calling get_commit_buffer() without calling unuse_commit_buffer() > on the memory, potentially leaking it. > > Signed-off-by: Junio C Hamano > -

[PATCH] fmt-merge-msg: plug small leak of commit buffer

A broken or badly formatted commit might not record author or committer lines; the function record_person() returned after calling get_commit_buffer() without calling unuse_commit_buffer() on the memory, potentially leaking it. Signed-off-by: Junio C Hamano --- * to be applied on bc6b8fc1 (use