Re: [PATCH] fetch-pack: write fetched refs to .promisor

2019-10-14 Thread Jonathan Tan
Thanks for your comments. Rearranging them: > This makes me wonder why we don't also change index-pack to write a > similar message to the .promisor. I guess there's potentially too much > information to shove all the refs on the command-line? index-pack already is capable of writing messages to

Re: [PATCH] fetch-pack: write fetched refs to .promisor

2019-10-14 Thread Josh Steadmon
I have a few questions below, but they're probably due to lack of a full understanding on my part of how packfiles are managed. On 2019.08.26 14:47, Jonathan Tan wrote: > The specification of promisor packfiles (in partial-clone.txt) states > that the .promisor files that accompany packfiles do no

Re: [PATCH] fetch-pack: write fetched refs to .promisor

2019-10-02 Thread Jeff King
On Thu, Sep 05, 2019 at 11:39:26AM -0700, Jonathan Tan wrote: > > I'm not really opposed to what you're doing here, but I did recently > > think of another possible use for .promisor files. So it seems like a > > good time to bring it up, since presumably we'd have to choose one or > > the other.

Re: [PATCH] fetch-pack: write fetched refs to .promisor

2019-09-05 Thread Jonathan Tan
> I'm not really opposed to what you're doing here, but I did recently > think of another possible use for .promisor files. So it seems like a > good time to bring it up, since presumably we'd have to choose one or > the other. Thanks for bringing it up - yes, we should discuss this. > I noticed

Re: [PATCH] fetch-pack: write fetched refs to .promisor

2019-09-05 Thread Jeff King
On Thu, Sep 05, 2019 at 10:13:24AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > But I wonder if it would make sense to keep a cache of these "cut > > points" in the partial clone. That's potentially smaller than the > > complete set of objects (especially for tree-based partial cloning

Re: [PATCH] fetch-pack: write fetched refs to .promisor

2019-09-05 Thread Junio C Hamano
Jeff King writes: > But I wonder if it would make sense to keep a cache of these "cut > points" in the partial clone. That's potentially smaller than the > complete set of objects (especially for tree-based partial cloning), and > it seems clear we're willing to store it in memory anyway. That s

Re: [PATCH] fetch-pack: write fetched refs to .promisor

2019-09-05 Thread Jeff King
On Mon, Aug 26, 2019 at 02:47:37PM -0700, Jonathan Tan wrote: > The specification of promisor packfiles (in partial-clone.txt) states > that the .promisor files that accompany packfiles do not matter (just > like .keep files), so whenever a packfile is fetched from the promisor > remote, Git has b

Re: [PATCH] fetch-pack: write fetched refs to .promisor

2019-08-27 Thread Jonathan Tan
> Jonathan Tan writes: > > > As written in the NEEDSWORK comment, repack does not preserve the > > contents of .promisor files, but I thought I'd send this out anyway as > > this change is already useful for users who don't run repack much. > > What do you exactly mean by "much" here? For diagn

Re: [PATCH] fetch-pack: write fetched refs to .promisor

2019-08-27 Thread Junio C Hamano
Jonathan Tan writes: > As written in the NEEDSWORK comment, repack does not preserve the > contents of .promisor files, but I thought I'd send this out anyway as > this change is already useful for users who don't run repack much. What do you exactly mean by "much" here? The comment sounds like

[PATCH] fetch-pack: write fetched refs to .promisor

2019-08-26 Thread Jonathan Tan
The specification of promisor packfiles (in partial-clone.txt) states that the .promisor files that accompany packfiles do not matter (just like .keep files), so whenever a packfile is fetched from the promisor remote, Git has been writing empty .promisor files. But these files could contain more u