Re: [PATCH] fetch-pack: start multi-head pulling.

2005-08-13 Thread Junio C Hamano
Matthias Urlichs <[EMAIL PROTECTED]> writes: >> I have been trying, admittably perhaps not very successfully, to >> stay away from bashism in the core GIT scripts. > > We should probably use #!/bin/bash for scripts with bashisms... As a fall-back position, yes, but I'd rather see trivial bashisms

Re: [PATCH] fetch-pack: start multi-head pulling.

2005-08-12 Thread Matthias Urlichs
Hi, Junio C Hamano wrote: > I have been trying, admittably perhaps not very successfully, to > stay away from bashism in the core GIT scripts. We should probably use #!/bin/bash for scripts with bashisms... -- Matthias Urlichs | {M:U} IT Design @ m-u-it.de | [EMAIL PROTECTED] Disclaimer:

Re: [PATCH] fetch-pack: start multi-head pulling.

2005-08-12 Thread Linus Torvalds
On Fri, 12 Aug 2005, Johannes Schindelin wrote: > > I seem to remember Junio does not like bash arrays... Well, fair enough, although they aren't really "bash" arrays, they appeared in other shells before "bash". At least ksh and zsh have them, although the zsh implementation seems to be pre

Re: [PATCH] fetch-pack: start multi-head pulling.

2005-08-12 Thread Junio C Hamano
Johannes Schindelin <[EMAIL PROTECTED]> writes: > I seem to remember Junio does not like bash arrays... And in a recent > commit message, he even admits to using something different than bash! Correct and somewhat misleading. My usual shell is bash but from time to time I try to run things with

Re: [PATCH] fetch-pack: start multi-head pulling.

2005-08-12 Thread Johannes Schindelin
Hi, On Fri, 12 Aug 2005, Linus Torvalds wrote: > Wouldn't it be simpler/cleaner to just do > > head=($(git-fetch-pack "$merge_repo" "$merge_head")) I seem to remember Junio does not like bash arrays... And in a recent commit message, he even admits to using something different than bash!

Re: [PATCH] fetch-pack: start multi-head pulling.

2005-08-12 Thread Linus Torvalds
On Fri, 12 Aug 2005, Junio C Hamano wrote: > > Linus, I need a bit of guidance from you about this one; an > ancient commit 4f7770c87ce3c302e1639a7737a6d2531fe4b160 removed > the multi-head support fetch-pack once had, labelling it as "a > misguided attempt", and I would like to know if I am maki

[PATCH] fetch-pack: start multi-head pulling.

2005-08-12 Thread Junio C Hamano
This is a beginning of resurrecting the multi-head pulling support for git-fetch-pack command. The git-fetch-script wrapper still only knows about fetching a single head, without renaming, so it is not very useful unless you directly call git-fetch-pack itself yet. It also fixes a longstanding ob