Re: [PATCH] fast-import: catch deletion of non-existent file in input

2012-07-15 Thread Jeff King
On Sun, Jul 15, 2012 at 01:11:51PM -0500, Jonathan Nieder wrote: > > Subject: fast-import: catch deletion of non-existent file in input > [...] > > We silently ignored the bogus "D foo" directive, and the > > resulting tree incorrectly contained "bar". With this patch, > > we notice the bogus inpu

Re: [PATCH] fast-import: catch deletion of non-existent file in input

2012-07-15 Thread Jonathan Nieder
Hi, Jeff King wrote: > Subject: fast-import: catch deletion of non-existent file in input [...] > We silently ignored the bogus "D foo" directive, and the > resulting tree incorrectly contained "bar". With this patch, > we notice the bogus input and die. This breaks svn-fe, which relies on the e

[PATCH] fast-import: catch deletion of non-existent file in input

2012-07-15 Thread Jeff King
On Fri, Jul 13, 2012 at 03:39:50PM +0200, Andreas Schwab wrote: > >> The output contains these lines: > >> > >> R a/b b/b > >> D a/b > >> > >> Changing the second line to D b/b fixes the bug. > > > > Yeah, I agree that is problematic. But I do not think it is a > > fast-import bug, but rather bo