Re: [PATCH] editor: use canonicalized absolute path

2013-07-30 Thread Junio C Hamano
Duy Nguyen writes: > The idea is the same, but my patch is a bit different (use of realpath > instead of real_path, I didn't remember git has real_path). I'm fine > with Ram being the author. Thanks, both of you, for clarification. >> Compared to not being able to edit, it may be a small price

Re: [PATCH] editor: use canonicalized absolute path

2013-07-30 Thread Duy Nguyen
On Mon, Jul 29, 2013 at 07:56:58AM -0700, Junio C Hamano wrote: > > diff --git a/editor.c b/editor.c > > index 27bdecd..0abbd8d 100644 > > --- a/editor.c > > +++ b/editor.c > > @@ -37,7 +37,7 @@ int launch_editor(const char *path, struct strbuf > > *buffer, const char *const *en > > re

Re: [PATCH] editor: use canonicalized absolute path

2013-07-29 Thread Duy Nguyen
On Mon, Jul 29, 2013 at 9:56 PM, Junio C Hamano wrote: >> Co-authored-by: Nguyễn Thái Ngọc Duy >> Signed-off-by: Ramkumar Ramachandra > > That's a bit strange---the patch text looks like the "how about > this" patch Duy posted earlier. Shouldn't it be From: Duy with > S-o-b: by two of you inste

Re: [PATCH] editor: use canonicalized absolute path

2013-07-29 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Junio C Hamano wrote: >> Ramkumar Ramachandra writes: >>> Junio C Hamano wrote: That's a bit strange---the patch text looks like the "how about this" patch Duy posted earlier. Shouldn't it be From: Duy with S-o-b: by two of you instead? >>> >>> Feel

Re: [PATCH] editor: use canonicalized absolute path

2013-07-29 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > Ramkumar Ramachandra writes: >> Junio C Hamano wrote: >>> That's a bit strange---the patch text looks like the "how about >>> this" patch Duy posted earlier. Shouldn't it be From: Duy with >>> S-o-b: by two of you instead? >> >> Feel free to amend as you see fit, as always

Re: [PATCH] editor: use canonicalized absolute path

2013-07-29 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Junio C Hamano wrote: >> That's a bit strange---the patch text looks like the "how about >> this" patch Duy posted earlier. Shouldn't it be From: Duy with >> S-o-b: by two of you instead? > > Feel free to amend as you see fit, as always. I was asking what is "corr

Re: [PATCH] editor: use canonicalized absolute path

2013-07-29 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > That's a bit strange---the patch text looks like the "how about > this" patch Duy posted earlier. Shouldn't it be From: Duy with > S-o-b: by two of you instead? Feel free to amend as you see fit, as always. > For editors that are not broken, this could be an annoying > re

Re: [PATCH] editor: use canonicalized absolute path

2013-07-29 Thread Junio C Hamano
Ramkumar Ramachandra writes: > By improving the relative_path() algorithm, e02ca72 (path.c: refactor > relative_path(), not only strip prefix, 2013-06-25) uncovered a latent > bug. While most editor applications like cat and vim handle > non-canonicalized relative paths fine, emacs does not. Th

Re: [PATCH] editor: use canonicalized absolute path

2013-07-29 Thread Duy Nguyen
On Sun, Jul 28, 2013 at 11:59 PM, Ramkumar Ramachandra wrote: > By improving the relative_path() algorithm, e02ca72 (path.c: refactor > relative_path(), not only strip prefix, 2013-06-25) uncovered a latent > bug. While most editor applications like cat and vim handle > non-canonicalized relative

[PATCH] editor: use canonicalized absolute path

2013-07-28 Thread Ramkumar Ramachandra
By improving the relative_path() algorithm, e02ca72 (path.c: refactor relative_path(), not only strip prefix, 2013-06-25) uncovered a latent bug. While most editor applications like cat and vim handle non-canonicalized relative paths fine, emacs does not. This is due to a long-standing bug in ema