Re: [PATCH] don't use test_must_fail with grep

2017-01-08 Thread Pranit Bauva
Hey Junio, On Sun, Jan 8, 2017 at 2:48 AM, Junio C Hamano wrote: > I see v3 that has 2>&1 but according to Luke's comment ("the message > comes from cat"), it shouldn't be there? I am behind clearing the > backlog in my mailbox and I could tweak it out from v3 while > queuing, or I may forget ab

Re: [PATCH] don't use test_must_fail with grep

2017-01-07 Thread Junio C Hamano
Pranit Bauva writes: > Hey Johannes, > > On Sun, Jan 1, 2017 at 8:20 PM, Johannes Sixt wrote: >> which makes me wonder: Is the message that we do expect not to occur >> actually printed on stdout? It sounds much more like an error message, i.e., >> text that is printed on stderr. Wouldn't we nee

Re: [PATCH] don't use test_must_fail with grep

2017-01-03 Thread Stefan Beller
On Sat, Dec 31, 2016 at 3:44 AM, Pranit Bauva wrote: > test_must_fail should only be used for testing git commands. To test the > failure of other commands use `!`. > > Reported-by: Stefan Beller > Signed-off-by: Pranit Bauva Thanks for writing up such a patch! I had put it on my todo list, but

Re: [PATCH] don't use test_must_fail with grep

2017-01-02 Thread Pranit Bauva
Hey Johannes, On Sun, Jan 1, 2017 at 8:20 PM, Johannes Sixt wrote: > which makes me wonder: Is the message that we do expect not to occur > actually printed on stdout? It sounds much more like an error message, i.e., > text that is printed on stderr. Wouldn't we need this? > > git p4 comm

Re: [PATCH] don't use test_must_fail with grep

2017-01-01 Thread Luke Diamand
On 1 January 2017 at 14:50, Johannes Sixt wrote: > Am 01.01.2017 um 15:23 schrieb Luke Diamand: >> >> On 31 December 2016 at 11:44, Pranit Bauva wrote: >>> >>> diff --git a/t/t9813-git-p4-preserve-users.sh >>> b/t/t9813-git-p4-preserve-users.sh >>> index 0fe231280..2384535a7 100755 >>> --- a/t/t9

Re: [PATCH] don't use test_must_fail with grep

2017-01-01 Thread Johannes Sixt
Am 01.01.2017 um 15:23 schrieb Luke Diamand: On 31 December 2016 at 11:44, Pranit Bauva wrote: diff --git a/t/t9813-git-p4-preserve-users.sh b/t/t9813-git-p4-preserve-users.sh index 0fe231280..2384535a7 100755 --- a/t/t9813-git-p4-preserve-users.sh +++ b/t/t9813-git-p4-preserve-users.sh @@ -126

Re: [PATCH] don't use test_must_fail with grep

2017-01-01 Thread Luke Diamand
On 31 December 2016 at 11:44, Pranit Bauva wrote: > test_must_fail should only be used for testing git commands. To test the > failure of other commands use `!`. > > Reported-by: Stefan Beller > Signed-off-by: Pranit Bauva > --- > t/t3510-cherry-pick-sequence.sh | 6 +++--- > t/t5504-fetch-re

[PATCH] don't use test_must_fail with grep

2016-12-31 Thread Pranit Bauva
test_must_fail should only be used for testing git commands. To test the failure of other commands use `!`. Reported-by: Stefan Beller Signed-off-by: Pranit Bauva --- t/t3510-cherry-pick-sequence.sh | 6 +++--- t/t5504-fetch-receive-strict.sh | 2 +- t/t5516-fetch-push.sh| 2 +-