Re: [PATCH] doc: improve usage string in MyFirstContribution

2019-06-21 Thread Eric Sunshine
On Fri, Jun 21, 2019 at 1:19 PM Junio C Hamano wrote: > Eric Sunshine writes: > > On Fri, Jun 21, 2019 at 6:43 AM Christian Couder > > wrote: > >> On Thu, Jun 20, 2019 at 11:29 PM Emily Shaffer > >> wrote: > >> > It doesn't require 1 or more args - you can run it with no args. So it > >> > mig

Re: [PATCH] doc: improve usage string in MyFirstContribution

2019-06-21 Thread Junio C Hamano
Eric Sunshine writes: > On Fri, Jun 21, 2019 at 6:43 AM Christian Couder > wrote: >> On Thu, Jun 20, 2019 at 11:29 PM Emily Shaffer >> wrote: >> > It doesn't require 1 or more args - you can run it with no args. So it >> > might be better suited to state the args as optional: >> > >> > 'git

Re: [PATCH] doc: improve usage string in MyFirstContribution

2019-06-21 Thread Eric Sunshine
On Fri, Jun 21, 2019 at 6:43 AM Christian Couder wrote: > On Thu, Jun 20, 2019 at 11:29 PM Emily Shaffer > wrote: > > It doesn't require 1 or more args - you can run it with no args. So it > > might be better suited to state the args as optional: > > > > 'git psuh [arg]...' > > Yeah sure, I wi

Re: [PATCH] doc: improve usage string in MyFirstContribution

2019-06-21 Thread Christian Couder
On Thu, Jun 20, 2019 at 11:29 PM Emily Shaffer wrote: > > On Thu, Jun 20, 2019 at 12:13:15AM +0200, Christian Couder wrote: > > SYNOPSIS > > > > [verse] > > -'git-psuh' > > +'git-psuh ...' > > It doesn't require 1 or more args - you can run it with no args. So it > might be better suit

Re: [PATCH] doc: improve usage string in MyFirstContribution

2019-06-20 Thread Emily Shaffer
On Thu, Jun 20, 2019 at 12:13:15AM +0200, Christian Couder wrote: > SYNOPSIS > > [verse] > -'git-psuh' > +'git-psuh ...' It doesn't require 1 or more args - you can run it with no args. So it might be better suited to state the args as optional: 'git psuh [arg]...' > > stati

[PATCH] doc: improve usage string in MyFirstContribution

2019-06-19 Thread Christian Couder
We implement a command called git-psuh which accept arguments, so let's show that it accepts arguments in the doc and the usage string. While at it, we need to prepare "a NULL-terminated array of usage strings", not just "a NULL-terminated usage string". Signed-off-by: Christian Couder --- Docu