Re: [PATCH] doc: fix merge-base ASCII art tab spacing

2016-10-21 Thread Philip Oakley
From: "Junio C Hamano" "Philip Oakley" writes: It appears that acciidoctor sees the art as being a separated mono-spaced block, with border/background as locally appropriate. While the asciidoc looks to simply change to mono-spaced text. FWIW, I changed my mind and your patch is now queued

Re: [PATCH] doc: fix merge-base ASCII art tab spacing

2016-10-21 Thread Jeff King
On Fri, Oct 21, 2016 at 10:26:29PM +0100, Philip Oakley wrote: > > updating the source they work on. Otherwise, the broken "doc-tool > > stack" will keep producing broken output next time a source that > > respects "tab is to skip to the next multiple of 8" rule is fed to > > it, no? > > By avoi

Re: [PATCH] doc: fix merge-base ASCII art tab spacing

2016-10-21 Thread Junio C Hamano
"Philip Oakley" writes: > It appears that acciidoctor sees the art as being a separated > mono-spaced block, with border/background as locally > appropriate. While the asciidoc looks to simply change to mono-spaced > text. FWIW, I changed my mind and your patch is now queued on 'next'. Thanks.

Re: [PATCH] doc: fix merge-base ASCII art tab spacing

2016-10-21 Thread Philip Oakley
From: "Junio C Hamano" Philip Oakley writes: The doc-tool stack does not always respect the 'tab = 8 spaces' rule, particularly the git-scm doc pages https://git-scm.com/docs/git-merge-base and the Git generated html pages. Sorry, but I do not understand this change. https://git.github.i

Re: [PATCH] doc: fix merge-base ASCII art tab spacing

2016-10-20 Thread Junio C Hamano
Jeff King writes: > On Fri, Oct 21, 2016 at 12:40:09AM +0100, Philip Oakley wrote: > >> The doc-tool stack does not always respect the 'tab = 8 spaces' rule, >> particularly the git-scm doc pages https://git-scm.com/docs/git-merge-base >> and the Git generated html pages. > > Hmm, I thought git-s

Re: [PATCH] doc: fix merge-base ASCII art tab spacing

2016-10-20 Thread Junio C Hamano
Philip Oakley writes: > The doc-tool stack does not always respect the 'tab = 8 spaces' rule, > particularly the git-scm doc pages https://git-scm.com/docs/git-merge-base > and the Git generated html pages. Sorry, but I do not understand this change. https://git.github.io/htmldocs/git-merge-bas

Re: [PATCH] doc: fix merge-base ASCII art tab spacing

2016-10-20 Thread Jeff King
On Fri, Oct 21, 2016 at 12:40:09AM +0100, Philip Oakley wrote: > The doc-tool stack does not always respect the 'tab = 8 spaces' rule, > particularly the git-scm doc pages https://git-scm.com/docs/git-merge-base > and the Git generated html pages. Hmm, I thought git-scm.com was fixed by: http

[PATCH] doc: fix merge-base ASCII art tab spacing

2016-10-20 Thread Philip Oakley
The doc-tool stack does not always respect the 'tab = 8 spaces' rule, particularly the git-scm doc pages https://git-scm.com/docs/git-merge-base and the Git generated html pages. Use just spaces within the block of the ascii art. Noticed when reviewing Junio's suggested update to `git merge-base`