Re: [PATCH] diffcore-pickaxe: simplify has_changes and contains

2013-07-07 Thread Junio C Hamano
Jeff King writes: > Before, if (!one && !two) we would call contains(two, ...), and now we > will simply assume it is zero. Which I think is an improvement, as we > would have segfaulted before. I don't think it is a bug in the current > code (we would not ever feed the function two NULLs), but i

Re: [PATCH] diffcore-pickaxe: simplify has_changes and contains

2013-07-06 Thread Jeff King
On Sat, Jul 06, 2013 at 03:53:27PM +0200, René Scharfe wrote: > Halve the number of callsites of contains() to two using temporary > variables, simplifying the code. While at it, get rid of the > diff_options parameter, which became unused with 8fa4b09f. There is a slight change in behavior, too

[PATCH] diffcore-pickaxe: simplify has_changes and contains

2013-07-06 Thread René Scharfe
Halve the number of callsites of contains() to two using temporary variables, simplifying the code. While at it, get rid of the diff_options parameter, which became unused with 8fa4b09f. Signed-off-by: René Scharfe --- diffcore-pickaxe.c | 11 --- 1 file changed, 4 insertions(+), 7 dele