Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

2017-12-06 Thread Eric Sunshine
On Wed, Dec 6, 2017 at 5:00 PM, Brandon Williams wrote: > On 12/05, Eric Sunshine wrote: >> 557a5998d (submodule: remove gitmodules_config, 2017-08-03) touched a >> fair number of built-in commands. It's not clear from the current >> patch's commit message if diff-tree is the only command which >>

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

2017-12-06 Thread Brandon Williams
On 12/05, Eric Sunshine wrote: > On Tue, Dec 5, 2017 at 5:13 PM, Brandon Williams wrote: > > A regression was introduced in 557a5998d (submodule: remove > > gitmodules_config, 2017-08-03) to how attribute processing was handled > > in bare repositories when running the diff-tree command. > > > > B

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

2017-12-06 Thread Brandon Williams
On 12/05, Stefan Beller wrote: > On Tue, Dec 5, 2017 at 2:13 PM, Brandon Williams wrote: > > A regression was introduced in 557a5998d (submodule: remove > > gitmodules_config, 2017-08-03) to how attribute processing was handled > > in bare repositories when running the diff-tree command. > > > > B

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

2017-12-05 Thread Eric Sunshine
On Tue, Dec 5, 2017 at 5:13 PM, Brandon Williams wrote: > A regression was introduced in 557a5998d (submodule: remove > gitmodules_config, 2017-08-03) to how attribute processing was handled > in bare repositories when running the diff-tree command. > > By default the attribute system will first t

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

2017-12-05 Thread Stefan Beller
On Tue, Dec 5, 2017 at 2:13 PM, Brandon Williams wrote: > A regression was introduced in 557a5998d (submodule: remove > gitmodules_config, 2017-08-03) to how attribute processing was handled > in bare repositories when running the diff-tree command. > > By default the attribute system will first t

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

2017-12-05 Thread Junio C Hamano
Brandon Williams writes: > A regression was introduced in 557a5998d (submodule: remove > gitmodules_config, 2017-08-03) to how attribute processing was handled > in bare repositories when running the diff-tree command. > > By default the attribute system will first try to read ".gitattribute" > f

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

2017-12-05 Thread Brandon Williams
On 12/05, Ben Boeckel wrote: > On Tue, Dec 05, 2017 at 14:13:37 -0800, Brandon Williams wrote: > > This patch should fix the regression. Let me know if it doesn't solve the > > issue and I'll investigate some more. > > Our test suite passes again. Thanks! Of course! Glad I could help :) > >

Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories

2017-12-05 Thread Ben Boeckel
On Tue, Dec 05, 2017 at 14:13:37 -0800, Brandon Williams wrote: > This patch should fix the regression. Let me know if it doesn't solve the > issue and I'll investigate some more. Our test suite passes again. Thanks! Acked-by: Ben Boeckel --Ben

[PATCH] diff-tree: read the index so attribute checks work in bare repositories

2017-12-05 Thread Brandon Williams
A regression was introduced in 557a5998d (submodule: remove gitmodules_config, 2017-08-03) to how attribute processing was handled in bare repositories when running the diff-tree command. By default the attribute system will first try to read ".gitattribute" files from the working tree and then fa