Re: [PATCH] diff-tree: obey the color.ui configuration

2017-12-30 Thread Christian Couder
On Sat, Dec 30, 2017 at 7:15 PM, Jeff King wrote: > On Sat, Dec 30, 2017 at 04:04:50PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> > I do like the idea of using "show", though. We know the point is to show >> > the output to the user, so we don't mind at all if the behavior or >> > output of show c

Re: [PATCH] diff-tree: obey the color.ui configuration

2017-12-30 Thread Jeff King
On Sat, Dec 30, 2017 at 04:04:50PM +0100, Ævar Arnfjörð Bjarmason wrote: > > I do like the idea of using "show", though. We know the point is to show > > the output to the user, so we don't mind at all if the behavior or > > output of show changes in future versions (unless we consider the final >

Re: [PATCH] diff-tree: obey the color.ui configuration

2017-12-30 Thread Ævar Arnfjörð Bjarmason
On Sat, Dec 30 2017, Jeff King jotted: > On Sat, Dec 30, 2017 at 01:33:06PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> > - we ended up with 33c643bb08 (Revert "color: check color.ui in >> > git_default_config()", 2017-10-13), which just reverts the whole >> > mess back to the pre-v2.14

Re: [PATCH] diff-tree: obey the color.ui configuration

2017-12-30 Thread Jeff King
On Sat, Dec 30, 2017 at 01:33:06PM +0100, Ævar Arnfjörð Bjarmason wrote: > > - we ended up with 33c643bb08 (Revert "color: check color.ui in > > git_default_config()", 2017-10-13), which just reverts the whole > > mess back to the pre-v2.14 state. This shipped in v2.15. > > Thanks. What

Re: [PATCH] diff-tree: obey the color.ui configuration

2017-12-30 Thread Ævar Arnfjörð Bjarmason
On Sat, Dec 30 2017, Jeff King jotted: > On Fri, Dec 29, 2017 at 06:16:31PM -0500, Todd Zullinger wrote: > >> Ævar Arnfjörð Bjarmason wrote: >> > No idea how to test this, in particular trying to pipe the output of >> > color.ui=never v.s. color.ui=auto to a file as "auto" will disable >> > color

Re: [PATCH] diff-tree: obey the color.ui configuration

2017-12-29 Thread Jeff King
On Fri, Dec 29, 2017 at 06:16:31PM -0500, Todd Zullinger wrote: > Ævar Arnfjörð Bjarmason wrote: > > No idea how to test this, in particular trying to pipe the output of > > color.ui=never v.s. color.ui=auto to a file as "auto" will disable > > coloring when it detects a pipe, but this fixes the i

Re: [PATCH] diff-tree: obey the color.ui configuration

2017-12-29 Thread Todd Zullinger
Ævar Arnfjörð Bjarmason wrote: > No idea how to test this, in particular trying to pipe the output of > color.ui=never v.s. color.ui=auto to a file as "auto" will disable > coloring when it detects a pipe, but this fixes the issue. You might be able to use similar methods as those Jeff used in the

[PATCH] diff-tree: obey the color.ui configuration

2017-12-29 Thread Ævar Arnfjörð Bjarmason
Before git-bisect exits it calls `diff-tree --pretty --stat $commit` on the bad commit. This would always print the "commit" line with coloring despite color.ui being set to "never". Teach diff-tree to look at the git_color_config() configuration. I initially tried to add this to git_diff_basic_co