Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-23 Thread Jeff King
On Thu, Jul 23, 2015 at 10:02:27PM +0200, Sebastian Schuberth wrote: > On Thu, Jul 23, 2015 at 8:08 PM, Jeff King wrote: > > > mode. Actually asking for a two-endpoint tree diff: > > > > git diff-tree --quiet --ignore-space-change $commit^ $commit > > > > will do what you want. > > Yes, I kno

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-23 Thread Junio C Hamano
Sebastian Schuberth writes: > On Thu, Jul 23, 2015 at 9:39 PM, Junio C Hamano wrote: > >> I haven't dug into why that happens, but possible ways to fix that >> are to make "--quiet" output all (making it consistent with "-s") or >> no (making the command totally silent) output at all ;-). > > Ex

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-23 Thread Sebastian Schuberth
On Thu, Jul 23, 2015 at 9:39 PM, Junio C Hamano wrote: > I haven't dug into why that happens, but possible ways to fix that > are to make "--quiet" output all (making it consistent with "-s") or > no (making the command totally silent) output at all ;-). Exactly, and I chose the latter to add so

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-23 Thread Sebastian Schuberth
On Thu, Jul 23, 2015 at 7:06 PM, Junio C Hamano wrote: > Existing scripts by definition would not be using a new option you > will invent that used not to be a valid one. So that would be one > way that you can shorten your script without breaking other people. True. If it was only for shorteni

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-23 Thread Sebastian Schuberth
On Thu, Jul 23, 2015 at 8:08 PM, Jeff King wrote: > mode. Actually asking for a two-endpoint tree diff: > > git diff-tree --quiet --ignore-space-change $commit^ $commit > > will do what you want. Yes, I know, thanks. But I deliberately wanted to specify only a single commit as an optimization,

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-23 Thread Junio C Hamano
Jeff King writes: > I have not been following the thread closely, but I do not recall seeing > anyone mention that the reason for the sha1-output is handing > only a single commit-ish to diff-tree is what puts it into its log-like > mode. Actually asking for a two-endpoint tree diff: > > git di

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-23 Thread Jeff King
On Thu, Jul 23, 2015 at 09:06:01AM +0200, Sebastian Schuberth wrote: > My use-case (also see [1]) is that I wanted to checked whether some > given commits change nothing but whitespace. So I did > > if git diff-tree --quiet --ignore-space-change $commit; then > echo "$commit only changes whit

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-23 Thread Junio C Hamano
Junio C Hamano writes: > Sebastian Schuberth writes: > >> Well, from a user's perspective it does not matter which part of the >> internal implementation of diff-tree is responsible for printing that >> single line,... > > That is not "internal implementation", but "logically separate > parts".

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-23 Thread Junio C Hamano
Sebastian Schuberth writes: > Well, from a user's perspective it does not matter which part of the > internal implementation of diff-tree is responsible for printing that > single line,... That is not "internal implementation", but "logically separate parts". View it more like "'git show -s' do

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-23 Thread Sebastian Schuberth
On Wed, Jul 22, 2015 at 10:32 PM, Junio C Hamano wrote: >> "--quite" is documented to "Disable all output of the program". Yet >> calling diff-tree with a single commit like >> >> $ git diff-tree --quiet c925fe2 >> >> was logging >> >> c925fe23684455735c3bb1903803643a24a58d8f > > At this point, u

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-22 Thread Junio C Hamano
Sebastian Schuberth writes: > "--quite" is documented to "Disable all output of the program". Yet > calling diff-tree with a single commit like > > $ git diff-tree --quiet c925fe2 > > was logging > > c925fe23684455735c3bb1903803643a24a58d8f At this point, unfortunately I think we need to call th

Re: [PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-22 Thread Johannes Schindelin
On 2015-07-22 11:29, Sebastian Schuberth wrote: > "--quite" is documented to "Disable all output of the program". s/--quite/quiet/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/

[PATCH] diff-tree: do not show the sha1 of the given head with --quiet

2015-07-22 Thread Sebastian Schuberth
"--quite" is documented to "Disable all output of the program". Yet calling diff-tree with a single commit like $ git diff-tree --quiet c925fe2 was logging c925fe23684455735c3bb1903803643a24a58d8f to the console despite "--quite" being given. This is inconsistent with both the docs and the beha