Re: [PATCH] diff-highlight: split code into module

2017-06-15 Thread Jeff King
On Thu, Jun 15, 2017 at 12:17:15PM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > >> contrib/diff-highlight/.gitignore | 2 ++ > >> .../{diff-highlight => DiffHighlight.pm} | 40 > >> +- > >> contrib/diff-highlight/Makefile

Re: [PATCH] diff-highlight: split code into module

2017-06-15 Thread Scott Baker
On 06/15/2017 12:15 PM, Junio C Hamano wrote: > Do you want +x bit for the last one? I could throw that bit in > while queuing if you want. > > Thanks. > Ya probably best.

Re: [PATCH] diff-highlight: split code into module

2017-06-15 Thread Junio C Hamano
Junio C Hamano writes: >> contrib/diff-highlight/.gitignore | 2 ++ >> .../{diff-highlight => DiffHighlight.pm} | 40 >> +- >> contrib/diff-highlight/Makefile| 21 ++-- >> contrib/diff-highlight/README

Re: [PATCH] diff-highlight: split code into module

2017-06-15 Thread Junio C Hamano
Jeff King writes: > The diff-so-fancy project is also written in perl, and most > of its users pipe diffs through both diff-highlight and > diff-so-fancy. It would be nice if this could be done in a > single script. So let's pull most of diff-highlight's code > into its own module which can be us

[PATCH] diff-highlight: split code into module

2017-06-15 Thread Jeff King
The diff-so-fancy project is also written in perl, and most of its users pipe diffs through both diff-highlight and diff-so-fancy. It would be nice if this could be done in a single script. So let's pull most of diff-highlight's code into its own module which can be used by diff-so-fancy. In addit