Re: [PATCH] diff-highlight: add some tests.

2016-08-22 Thread Jeff King
On Mon, Aug 22, 2016 at 08:55:39AM -0700, Brian Henderson wrote: > Jeff, I love your idea. how's this looking? Much more readable, IMHO. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

[PATCH] diff-highlight: add some tests.

2016-08-22 Thread Brian Henderson
Jeff, I love your idea. how's this looking? Junio, I wasn't meaning to be stubborn, although definitely a fault of mine. I understand a lot better now, thanks for your patience. --- contrib/diff-highlight/Makefile | 5 + contrib/diff-highlight/t/Makefile| 22 +

Re: [PATCH] diff-highlight: add some tests.

2016-08-19 Thread Junio C Hamano
Jeff King writes: > For that matter, I'm not sure that: > > cat >a <<-\EOF && > aaa > bbb > ccc > EOF > > cat >b <<-\EOF && > aaa > 0bb > ccc > EOF > > dh_test a b <<\EOF > aaa > -${CW}b${CR}bb > +${CW}0${CR}bb > EOF > > isn't more readable, too. It's more lines, cer

Re: [PATCH] diff-highlight: add some tests.

2016-08-19 Thread Junio C Hamano
Brian Henderson writes: > +# dh_test is a test helper function which takes 1) some file data, 2) some > +# change of the file data, creates a diff and commit of the changes and > passes > +# that through diff-highlight. > +# The optional 3rd parameter is the expected output of diff-highlight min

Re: [PATCH] diff-highlight: add some tests.

2016-08-19 Thread Jeff King
On Fri, Aug 19, 2016 at 01:44:28PM -0700, Junio C Hamano wrote: > Brian Henderson writes: > > > Junio, how does this look? > > ... > > +# dh_test is a test helper function which takes 1) some file data, 2) some > > +# change of the file data, creates a diff and commit of the changes and > > pas

Re: [PATCH] diff-highlight: add some tests.

2016-08-19 Thread Junio C Hamano
Brian Henderson writes: > Junio, how does this look? > ... > +# dh_test is a test helper function which takes 1) some file data, 2) some > +# change of the file data, creates a diff and commit of the changes and > passes > +# that through diff-highlight. > +# The optional 3rd parameter is the ex

[PATCH] diff-highlight: add some tests.

2016-08-19 Thread Brian Henderson
Junio, how does this look? Signed-off-by: Brian Henderson --- contrib/diff-highlight/Makefile | 5 + contrib/diff-highlight/t/Makefile| 22 contrib/diff-highlight/t/t9400-diff-highlight.sh | 122 +++ 3 files changed, 149 insertions(+)