Re: [PATCH] diff: skip GITLINK when lazy fetching missing objs

2019-08-22 Thread Jeff King
On Thu, Aug 22, 2019 at 09:25:34AM -0700, Jonathan Tan wrote: > > The batch fetch is purely an optimization, because we'd eventually fetch > > the individual objects on demand. If the batch one fails, should we > > continue with the operation? That leaves any error-handling for the > > overall ope

Re: [PATCH] diff: skip GITLINK when lazy fetching missing objs

2019-08-22 Thread Jonathan Tan
> I wondered what would happen when it does not succeed. It looks like the > whole diff process just dies. > > The batch fetch is purely an optimization, because we'd eventually fetch > the individual objects on demand. If the batch one fails, should we > continue with the operation? That leaves a

Re: [PATCH] diff: skip GITLINK when lazy fetching missing objs

2019-08-21 Thread Jeff King
On Tue, Aug 20, 2019 at 02:39:24PM -0700, Jonathan Tan wrote: > > Jonathan Tan writes: > > > > > In 7fbbcb21b1 ("diff: batch fetching of missing blobs", 2019-04-08), > > > diff was taught to batch the fetching of missing objects when operating > > > on a partial clone, but was not taught to refr

Re: [PATCH] diff: skip GITLINK when lazy fetching missing objs

2019-08-20 Thread Jonathan Tan
> Jonathan Tan writes: > > > In 7fbbcb21b1 ("diff: batch fetching of missing blobs", 2019-04-08), > > diff was taught to batch the fetching of missing objects when operating > > on a partial clone, but was not taught to refrain from fetching > > GITLINKs. Teach diff to check if an object is a GIT

Re: [PATCH] diff: skip GITLINK when lazy fetching missing objs

2019-08-20 Thread Junio C Hamano
Jonathan Tan writes: > In 7fbbcb21b1 ("diff: batch fetching of missing blobs", 2019-04-08), > diff was taught to batch the fetching of missing objects when operating > on a partial clone, but was not taught to refrain from fetching > GITLINKs. Teach diff to check if an object is a GITLINK before

[PATCH] diff: skip GITLINK when lazy fetching missing objs

2019-08-20 Thread Jonathan Tan
In 7fbbcb21b1 ("diff: batch fetching of missing blobs", 2019-04-08), diff was taught to batch the fetching of missing objects when operating on a partial clone, but was not taught to refrain from fetching GITLINKs. Teach diff to check if an object is a GITLINK before including it in the set to be f