Re: [PATCH] diff: run arguments through precompose_argv

Alexander Rinass writes: > I will create a v2 patch until the weekend and send it to the mailing list. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htm

Re: [PATCH] diff: run arguments through precompose_argv

> On 12 May 2016, at 00:08, Junio C Hamano wrote: > > Alexander Rinass writes: > >>> On 05 Apr 2016, at 21:15, Johannes Sixt wrote: >>> >>> Am 05.04.2016 um 19:09 schrieb Junio C Hamano: > Thanks-to: Torsten Bögershausen >>> >>> I sense NFD disease: The combining diaresis should combin

Re: [PATCH] diff: run arguments through precompose_argv

Alexander Rinass writes: >> On 05 Apr 2016, at 21:15, Johannes Sixt wrote: >> >> Am 05.04.2016 um 19:09 schrieb Junio C Hamano: Thanks-to: Torsten Bögershausen >> >> I sense NFD disease: The combining diaresis should combine with the o, not >> the g. Here is a correct line to copy-and-

Re: [PATCH] diff: run arguments through precompose_argv

Torsten Bögershausen writes: > May be something like this, (but this is highly a personal taste question) My observation was not a suggestion to rewrite the log message, but primarily about describing the change in behaviour. I didn't mean to nitpick the phrasing but let me think aloud about it

Re: [PATCH] diff: run arguments through precompose_argv

On 06.04.16 08:51, Alexander Rinass wrote: > >> On 05 Apr 2016, at 21:15, Johannes Sixt wrote: >> >> Am 05.04.2016 um 19:09 schrieb Junio C Hamano: Thanks-to: Torsten Bögershausen >> >> I sense NFD disease: The combining diaresis should combine with the o, not >> the g. Here is a correct

Re: [PATCH] diff: run arguments through precompose_argv

> On 05 Apr 2016, at 21:15, Johannes Sixt wrote: > > Am 05.04.2016 um 19:09 schrieb Junio C Hamano: >>> Thanks-to: Torsten Bögershausen > > I sense NFD disease: The combining diaresis should combine with the o, not > the g. Here is a correct line to copy-and-paste if you like: > > Thanks-to

Re: [PATCH] diff: run arguments through precompose_argv

Torsten Bögershausen writes: > On 05.04.16 21:15, Johannes Sixt wrote: >> Am 05.04.2016 um 19:09 schrieb Junio C Hamano: Thanks-to: Torsten Bögershausen >> >> I sense NFD disease: The combining diaresis should combine with the o, not >> the g. Here is a correct line to copy-and-paste if

Re: [PATCH] diff: run arguments through precompose_argv

On 05.04.16 21:15, Johannes Sixt wrote: > Am 05.04.2016 um 19:09 schrieb Junio C Hamano: >>> Thanks-to: Torsten Bögershausen > > I sense NFD disease: The combining diaresis should combine with the o, not > the g. Here is a correct line to copy-and-paste if you like: > > Thanks-to: Torsten Böge

Re: [PATCH] diff: run arguments through precompose_argv

Am 05.04.2016 um 19:09 schrieb Junio C Hamano: Thanks-to: Torsten Bögershausen I sense NFD disease: The combining diaresis should combine with the o, not the g. Here is a correct line to copy-and-paste if you like: Thanks-to: Torsten Bögershausen -- Hannes -- To unsubscribe from this li

Re: [PATCH] diff: run arguments through precompose_argv

Alexander Rinass writes: > File paths containing decomposed unicode chars passed to diff > command are not converted to precomposed unicode form. > > As a result, no diff is displayed when feeding such a file path to the > diff command. > > Opposite to most builtin commands, the diff builtin is m

[PATCH] diff: run arguments through precompose_argv

File paths containing decomposed unicode chars passed to diff command are not converted to precomposed unicode form. As a result, no diff is displayed when feeding such a file path to the diff command. Opposite to most builtin commands, the diff builtin is missing the parse_options call, which in

[PATCH] diff: run arguments through precompose_argv

I found an issue where file paths containing decomposed unicode chars are not converted to precomposed unicode form when passed to the diff command family. As a result, no diff is displayed. With the help of Torsten Bögershausen and Junio C Hamano I came up with the following patch to fix the is