Re: [PATCH] diff: reuse diff setup for --no-index case

2019-02-24 Thread Junio C Hamano
Jeff King writes: >> Here's an attempt at that. I did drop a few comments that seemed >> pointless to me, as they're just re-stating the lines they describe. > > It looks like the original got merged to next. I think we at least need > to deal with the "Otherwise..." comment, but I think the lay

Re: [PATCH] diff: reuse diff setup for --no-index case

2019-02-24 Thread Jeff King
On Sat, Feb 16, 2019 at 01:57:56AM -0500, Jeff King wrote: > On Thu, Feb 14, 2019 at 11:47:02AM -0800, Junio C Hamano wrote: > > > > + if (no_index) > > > + /* If this is a no-index diff, just run it and exit there. */ > > > + diff_no_index(&rev, argc, argv); > > > + > > > if (n

Re: [PATCH] diff: reuse diff setup for --no-index case

2019-02-15 Thread Jeff King
did drop a few comments that seemed pointless to me, as they're just re-stating the lines they describe. -- >8 -- Subject: [PATCH] diff: reuse diff setup for --no-index case When "--no-index" is in effect (or implied by the arguments), git-diff jumps early to a special code path

Re: [PATCH] diff: reuse diff setup for --no-index case

2019-02-14 Thread Junio C Hamano
Jeff King writes: > Subject: [PATCH] diff: reuse diff setup for --no-index case > > When "--no-index" is in effect (or implied by the arguments), git-diff > jumps early to a special code path to perform that diff. This means we > miss out on some settings like enabling

[PATCH] diff: reuse diff setup for --no-index case

2019-02-13 Thread Jeff King
" when possible, though. Maybe we should do something like the patch below? -- >8 -- Subject: [PATCH] diff: reuse diff setup for --no-index case When "--no-index" is in effect (or implied by the arguments), git-diff jumps early to a special code path to perform that diff. This means we