Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Thomas Gummerer
[Sorry for not seeing this before sending out v2.] Junio C Hamano writes: > Thomas Gummerer writes: > >> git diff --no-index ... currently reads the index, during setup, when >> calling gitmodules_config(). In the usual case this gives us some >> performance drawbacks, but it's especially ann

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Junio C Hamano
Thomas Gummerer writes: > git diff --no-index ... currently reads the index, during setup, when > calling gitmodules_config(). In the usual case this gives us some > performance drawbacks, but it's especially annoying if there is a broken > index file. > > Avoid calling the unnecessary gitmodule

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Jonathan Nieder
Thomas Gummerer wrote: > For example I would take one > version, use test-dump-cache-tree to dump the cache tree to a file, > change the format slightly, use test-dump-cache-tree again, and check > the difference with "git diff --no-index". Makes a lot of

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Thomas Gummerer
Jonathan Nieder writes: > Thomas Gummerer wrote: > >> git diff --no-index ... currently reads the index, during setup, when >> calling gitmodules_config(). In the usual case this gives us some >> performance drawbacks, > > Makes sense. > >>but it's especially annoying if

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Jonathan Nieder
Jens Lehmann wrote: > Am 09.12.2013 16:16, schrieb Jonathan Nieder: >> Thomas Gummerer wrote: >>> git diff --no-index ... currently reads the index, during setup, when >>> calling gitmodules_config(). In the usual case this gives us some >>> performance drawbacks, >> >> Makes sense. > > Hmm, but

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Jens Lehmann
Am 09.12.2013 16:16, schrieb Jonathan Nieder: > Thomas Gummerer wrote: > >> git diff --no-index ... currently reads the index, during setup, when >> calling gitmodules_config(). In the usual case this gives us some >> performance drawbacks, > > Makes sense. Hmm, but this will disable the submod

Re: [PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Jonathan Nieder
Thomas Gummerer wrote: > git diff --no-index ... currently reads the index, during setup, when > calling gitmodules_config(). In the usual case this gives us some > performance drawbacks, Makes sense. >but it's especially annoying if there is a broken > index file. Is t

[PATCH] diff: don't read index when --no-index is given

2013-12-09 Thread Thomas Gummerer
git diff --no-index ... currently reads the index, during setup, when calling gitmodules_config(). In the usual case this gives us some performance drawbacks, but it's especially annoying if there is a broken index file. Avoid calling the unnecessary gitmodules_config() when the --no-index option