Re: [PATCH] diff: clarify textconv interface

2016-02-22 Thread Duy Nguyen
On Tue, Feb 23, 2016 at 1:28 AM, Jeff King wrote: > On Mon, Feb 22, 2016 at 01:06:45PM -0500, Jeff King wrote: > >> I have a feeling you were confused by the fact that fill_textconv() >> does: > > Looking over it, I agree this is a pretty confusing interface that grew > out of control over time.

[PATCH] diff: clarify textconv interface

2016-02-22 Thread Jeff King
ent, but if somebody really wants to dig into refactoring it, be my guest. -- >8 -- Subject: [PATCH] diff: clarify textconv interface The memory allocation scheme for the textconv interface is a bit tricky, and not well documented. It was originally designed as an internal part of diff.c (matchi