Re: [PATCH] daemon.c: mark a file-local symbol as static

2016-02-22 Thread Ramsay Jones
On 22/02/16 21:18, Jeff King wrote: > On Mon, Feb 22, 2016 at 12:33:23AM +, Ramsay Jones wrote: > >>> Thanks, will do. You notice these with sparse, as I recall? I've meant >>> to look into running that myself, but it looks like we are not >>> warning-free with sparse currently. I see compla

Re: [PATCH] daemon.c: mark a file-local symbol as static

2016-02-22 Thread Jeff King
On Mon, Feb 22, 2016 at 12:33:23AM +, Ramsay Jones wrote: > > Thanks, will do. You notice these with sparse, as I recall? I've meant > > to look into running that myself, but it looks like we are not > > warning-free with sparse currently. I see complaints like: > > > > connect.c:377:40: wa

Re: [PATCH] daemon.c: mark a file-local symbol as static

2016-02-21 Thread Ramsay Jones
On 21/02/16 23:25, Jeff King wrote: > On Sun, Feb 21, 2016 at 05:33:38PM +, Ramsay Jones wrote: > >> If you need to re-roll your 'jk/tighten-alloc' branch, could you >> please squash this into the relevant patch. (ie. "convert manual >> allocations to argv_array"). > > Thanks, will do. You

Re: [PATCH] daemon.c: mark a file-local symbol as static

2016-02-21 Thread Jeff King
On Sun, Feb 21, 2016 at 05:33:38PM +, Ramsay Jones wrote: > If you need to re-roll your 'jk/tighten-alloc' branch, could you > please squash this into the relevant patch. (ie. "convert manual > allocations to argv_array"). Thanks, will do. You notice these with sparse, as I recall? I've meant

[PATCH] daemon.c: mark a file-local symbol as static

2016-02-21 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Jeff, If you need to re-roll your 'jk/tighten-alloc' branch, could you please squash this into the relevant patch. (ie. "convert manual allocations to argv_array"). Thanks! ATB, Ramsay Jones daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d