Re: [PATCH] daemon: add --no-syslog to undo implicit --syslog

2018-01-24 Thread Lucas Werkmeister
On 24.01.2018 19:33, Junio C Hamano wrote: > Lucas Werkmeister writes: > >>> Moreover, --detach completely dissociates the process from the >>> original set of standard file descriptors by first closing them and >>> then connecting it to "/dev/null", so it will be nonsense to use this >>> new opt

Re: [PATCH] daemon: add --no-syslog to undo implicit --syslog

2018-01-24 Thread Junio C Hamano
Lucas Werkmeister writes: >> Moreover, --detach completely dissociates the process from the >> original set of standard file descriptors by first closing them and >> then connecting it to "/dev/null", so it will be nonsense to use this >> new option with it. > > Ah, I wasn’t aware of that – so wi

Re: [PATCH] daemon: add --no-syslog to undo implicit --syslog

2018-01-24 Thread Lucas Werkmeister
On 23.01.2018 23:06, Lucas Werkmeister wrote: > Ah, I wasn’t aware of that – so with --detach, --no-syslog would be > better described as “disables all logging” rather than “log to stderr > instead”. IMHO it would still make sense to have the --no-syslog option > (then mainly for use with --inetd)

Re: [PATCH] daemon: add --no-syslog to undo implicit --syslog

2018-01-23 Thread Lucas Werkmeister
Thanks for your responses! On 23.01.2018 01:00, Ævar Arnfjörð Bjarmason wrote: > This patch looks good, but I wonder if with the rise of systemd > there's a good reason to flip the default around to not having other > stuff imply --syslog, and have users specify this implictly, then we > won't nee

Re: [PATCH] daemon: add --no-syslog to undo implicit --syslog

2018-01-23 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Mon, Jan 22 2018, Lucas Werkmeister jotted: > >> Several options imply --syslog, without there being a way to disable it >> again. This commit adds that option. > > Just two options imply --syslog, --detach & --inetd, unless I've missed > something, anyway 2 !

Re: [PATCH] daemon: add --no-syslog to undo implicit --syslog

2018-01-22 Thread Ævar Arnfjörð Bjarmason
On Mon, Jan 22 2018, Lucas Werkmeister jotted: > Several options imply --syslog, without there being a way to disable it > again. This commit adds that option. Just two options imply --syslog, --detach & --inetd, unless I've missed something, anyway 2 != several, so maybe just say "The --detach

[PATCH] daemon: add --no-syslog to undo implicit --syslog

2018-01-22 Thread Lucas Werkmeister
Several options imply --syslog, without there being a way to disable it again. This commit adds that option. This is useful, for instance, when running `git daemon` as a systemd service with --inetd. systemd connects stderr to the journal by default, so logging to stderr is useful. On the other ha