Re: [PATCH] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
On Mon, May 27, 2013 at 10:28 PM, John Szakmeister wrote: [snip] > > You'll need to read Documentation/SubmittingPatches (here's a link to > a version online: > https://github.com/git/git/blob/master/Documentation/SubmittingPatches). > > You should resend this patch with the fix and change "[PATCH

Re: [PATCH] credential-osxkeychain: support more protocols

2013-05-27 Thread John Szakmeister
On Mon, May 27, 2013 at 9:55 AM, Xidorn Quan wrote: [snip] > I thought that SSH password logins can benefit from it, but I just > found that it is wrong because it seems that SSH client is responsible > for authenticating. Consequently, supporting SSH here is useless. > I will remove that lines an

Re: [PATCH] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
On Mon, May 27, 2013 at 6:27 PM, John Szakmeister wrote: > > On Mon, May 27, 2013 at 3:57 AM, Xidorn Quan wrote: > > Add protocol ftp, smtp, and ssh for credential-osxkeychain. > > --- > > contrib/credential/osxkeychain/git-credential-osxkeychain.c | 8 +++- > > 1 file changed, 7 insertions(

Re: [PATCH] credential-osxkeychain: support more protocols

2013-05-27 Thread John Szakmeister
On Mon, May 27, 2013 at 3:57 AM, Xidorn Quan wrote: > Add protocol ftp, smtp, and ssh for credential-osxkeychain. > --- > contrib/credential/osxkeychain/git-credential-osxkeychain.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/contrib/credential/osxkeychain/git-

[PATCH] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
Add protocol ftp, smtp, and ssh for credential-osxkeychain. --- contrib/credential/osxkeychain/git-credential-osxkeychain.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/contrib/credential/osxkeychain/git-credential-osxkeychain.c b/contrib/credential/osxkeychain/git-c