Re: [PATCH] credential-cache: interpret an ECONNRESET as on EOF

2017-07-27 Thread Ramsay Jones
Hi Junio, I just noticed a typo in the subject line for this patch. It should read '... ECONNRESET as _an_ EOF' not '... ECONNRESET as _on_ EOF'. [complete patch snipped!] Thanks! ATB, Ramsay Jones

Re: [PATCH] credential-cache: interpret an ECONNRESET as on EOF

2017-07-27 Thread Jeff King
On Thu, Jul 27, 2017 at 03:42:36PM +0100, Ramsay Jones wrote: > yep, I did think about adding a FLAG_EXIT (or somesuch) and passing > it down through the call stack to send_request() so that I could do > the check only for the 'exit' command. I decided against it in the > end, obviously! ;-) I ha

Re: [PATCH] credential-cache: interpret an ECONNRESET as on EOF

2017-07-27 Thread Ramsay Jones
On 27/07/17 15:17, Jeff King wrote: > On Thu, Jul 27, 2017 at 02:08:40AM +0100, Ramsay Jones wrote: > >> In order to suppress the fatal exit in this case, check the read error >> for an ECONNRESET and return as if no data was read from the daemon. >> This effectively converts an ECONNRESET into

Re: [PATCH] credential-cache: interpret an ECONNRESET as on EOF

2017-07-27 Thread Jeff King
On Thu, Jul 27, 2017 at 02:08:40AM +0100, Ramsay Jones wrote: > In order to suppress the fatal exit in this case, check the read error > for an ECONNRESET and return as if no data was read from the daemon. > This effectively converts an ECONNRESET into an EOF. Yeah, I think this is a perfectly re

[PATCH] credential-cache: interpret an ECONNRESET as on EOF

2017-07-26 Thread Ramsay Jones
Since commit 612c49e94d ("credential-cache: add tests for XDG functionality", 17-03-2017), the cygwin build has been failing all the new tests added by that commit. In particular, the 'git credential-cache exit' command, as part of the test cleanup code, has been die-ing with the message: fat