Re: [PATCH] convert any hard coded .gitmodules file string to the MACRO

2017-08-02 Thread Brandon Williams
On 08/01, Junio C Hamano wrote: > Stefan Beller writes: > > >>> @@ -233,18 +233,18 @@ void gitmodules_config(void) > >>> strbuf_addstr(&gitmodules_path, "/.gitmodules"); > >> > >> > >> Did you mean to also change "/.gitmodules" ?? > > > > Goog point. We should pick that up as we

Re: [PATCH] convert any hard coded .gitmodules file string to the MACRO

2017-08-02 Thread Brandon Williams
On 08/01, Junio C Hamano wrote: > Stefan Beller writes: > > >>> @@ -233,18 +233,18 @@ void gitmodules_config(void) > >>> strbuf_addstr(&gitmodules_path, "/.gitmodules"); > >> > >> > >> Did you mean to also change "/.gitmodules" ?? > > > > Goog point. We should pick that up as we

Re: [PATCH] convert any hard coded .gitmodules file string to the MACRO

2017-08-01 Thread Junio C Hamano
Stefan Beller writes: >>> @@ -233,18 +233,18 @@ void gitmodules_config(void) >>> strbuf_addstr(&gitmodules_path, "/.gitmodules"); >> >> >> Did you mean to also change "/.gitmodules" ?? > > Goog point. We should pick that up as well. However as we do not have > a macro for that,

Re: [PATCH] convert any hard coded .gitmodules file string to the MACRO

2017-08-01 Thread Stefan Beller
On Tue, Aug 1, 2017 at 6:14 AM, Jeff Hostetler wrote: > > > On 7/31/2017 7:11 PM, Stefan Beller wrote: >> >> I used these commands: >>$ cat sem.cocci >>@@ >>@@ >>- ".gitmodules" >>+ GITMODULES_FILE >> >>$ spatch --in-place --sp-file sem.cocci builtin/*.c *.c *.h >> >> Feel

Re: [PATCH] convert any hard coded .gitmodules file string to the MACRO

2017-08-01 Thread Jeff Hostetler
On 7/31/2017 7:11 PM, Stefan Beller wrote: I used these commands: $ cat sem.cocci @@ @@ - ".gitmodules" + GITMODULES_FILE $ spatch --in-place --sp-file sem.cocci builtin/*.c *.c *.h Feel free to regenerate or squash it in or have it as a separate commit. Signed-off-by: Stef

[PATCH] convert any hard coded .gitmodules file string to the MACRO

2017-07-31 Thread Stefan Beller
I used these commands: $ cat sem.cocci @@ @@ - ".gitmodules" + GITMODULES_FILE $ spatch --in-place --sp-file sem.cocci builtin/*.c *.c *.h Feel free to regenerate or squash it in or have it as a separate commit. Signed-off-by: Stefan Beller --- submodule.c| 18 +