Re: [PATCH] contrib: GnomeKeyring support + generic helper implementation

2012-08-26 Thread Philipp A. Hartmann
n 26/08/12 19:46, Junio C Hamano wrote: > Junio C Hamano writes: > >> Jeff King writes: >> >>> However, the shared bits are simple enough that maybe that is not a >>> concern. An interesting test would be to add a 5/4 porting Erik's win32 >>> credential helper, since that is the platform least l

Re: [PATCH] contrib: GnomeKeyring support + generic helper implementation

2012-08-26 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> However, the shared bits are simple enough that maybe that is not a >> concern. An interesting test would be to add a 5/4 porting Erik's win32 >> credential helper, since that is the platform least like our other ones. > > Very true. > >> So I am O

Re: [PATCH] contrib: GnomeKeyring support + generic helper implementation

2012-08-24 Thread Junio C Hamano
Jeff King writes: > However, the shared bits are simple enough that maybe that is not a > concern. An interesting test would be to add a 5/4 porting Erik's win32 > credential helper, since that is the platform least like our other ones. Very true. > So I am OK with this series, but I am also OK

Re: [PATCH] contrib: GnomeKeyring support + generic helper implementation

2012-08-24 Thread Jeff King
On Fri, Aug 24, 2012 at 11:15:36AM -0700, Junio C Hamano wrote: > > The third and fourth patches port the existing helpers to this generic > > implementation. > > > It struck me somewhat odd to see a new one added as the first step > in the series, and then "the generic", the third patch only to

Re: [PATCH] contrib: GnomeKeyring support + generic helper implementation

2012-08-24 Thread Junio C Hamano
"Philipp A. Hartmann" writes: > All, > > the following patch series proposes enhancements to the credential helper > implementations in the contrib section. The detailed development history > can be found at GitHub [1]. > > The first patch adds a GnomeKeyring credential backend. The GnomeKeyr

[PATCH] contrib: GnomeKeyring support + generic helper implementation

2012-08-23 Thread Philipp A. Hartmann
All, the following patch series proposes enhancements to the credential helper implementations in the contrib section. The detailed development history can be found at GitHub [1]. The first patch adds a GnomeKeyring credential backend. The GnomeKeyring specific parts are based on the work by