Re: [PATCH] contrib/subtree: unwrap tag refs

2015-11-12 Thread Jeff King
On Thu, Nov 12, 2015 at 10:36:16PM -0600, David A. Greene wrote: > > + sub="$(git rev-parse "$b^0")" || die "could not > > rev-parse split hash $b from commit $sq" > > This seems like odd quoting. Would not this do the same? > > sub="$(gi

Re: [PATCH] contrib/subtree: unwrap tag refs

2015-11-12 Thread David A. Greene
Rob Mayoff writes: > diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh > index 9f06571..b051600 100755 > --- a/contrib/subtree/git-subtree.sh > +++ b/contrib/subtree/git-subtree.sh > @@ -245,7 +245,10 @@ find_latest_squash() > case "$a" in >

[PATCH] contrib/subtree: unwrap tag refs

2015-11-12 Thread Rob Mayoff
From: Rob Mayoff If a subtree was added using a tag ref, the tag ref is stored in the subtree commit message instead of the underlying commit's ref. To split or push subsequent changes to the subtree, the subtree command needs to unwrap the tag ref. This patch makes it do so. The problem was de