Parker Moore writes:
> From: Parker Moore
>
> This fixes contrib/persistent-https builds for Go v1.7+ and is
> compatible with Go v1.0+.
Thanks, applied.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info a
From: Parker Moore
This fixes contrib/persistent-https builds for Go v1.7+ and is
compatible with Go v1.0+.
Running `make all` in `contrib/persistent-https` results in a failure
on Go 1.7 and above.
Specifically, the error is:
go build -o git-remote-persistent-https \
-ldflags "-X main.
Parker Moore writes:
>> the logical place to pull that information from would be
>> ../../GIT-VERSION-FILE,
>
> I agree. It would make more sense to build this to a specific version
> or git revision rather
> than a time. Perhaps that would be a different patch?
It would definitely be a separat
> the logical place to pull that information from would be
> ../../GIT-VERSION-FILE,
I agree. It would make more sense to build this to a specific version
or git revision rather
than a time. Perhaps that would be a different patch?
> So unless the "dynamic lookup in the Makefile" turns out to be
Shawn Pearce writes:
> On Mon, Jul 18, 2016 at 9:32 PM, Parker Moore wrote:
>>> The label does not even identify the version of the source in any way, so I
>>> am not sure how people are depending on that feature anyway ;-)
>>
>> Would it be a better solution simply to remove this build flag?
>
On Mon, Jul 18, 2016 at 9:32 PM, Parker Moore wrote:
>> The label does not even identify the version of the source in any way, so I
>> am not sure how people are depending on that feature anyway ;-)
>
> Would it be a better solution simply to remove this build flag?
> Alternatively, if Git wished
> The label does not even identify the version of the source in any way, so I
> am not sure how people are depending on that feature anyway ;-)
Would it be a better solution simply to remove this build flag?
Alternatively, if Git wished to support Go v1.5 and below, I would be
more than happy to
Jeff King writes:
>> This `name=value` syntax for the -X flag was introduced in Go v1.5
>> (released Aug 19, 2015):
>>
>> - release notes: https://golang.org/doc/go1.5#link
>> - commit:
>> https://github.com/golang/go/commit/12795c02f3d6fc54ece09a86e70aaa40a94d5131
>>
>> In Go v1.7, support fo
[+cc Shawn, who participated in the original discussion, as I don't
think Colby really works on git any more]
On Fri, Jul 15, 2016 at 01:44:14PM -0700, Parker Moore wrote:
> From: Parker Moore
>
> This fixes contrib/persistent-https builds for Go v1.7+ and is
> compatible with Go v1.5+.
>
>
From: Parker Moore
This fixes contrib/persistent-https builds for Go v1.7+ and is
compatible with Go v1.5+.
Running `make all` in `contrib/persistent-https` results in a failure
on Go 1.7 and above.
Specifically, the error is:
go build -o git-remote-persistent-https \
-ldflags "-X main.
10 matches
Mail list logo
