Re: [PATCH] contrib/completion: suppress stderror in bash

2015-03-04 Thread SZEDER Gábor
Hi, Quoting SZEDER Gábor : Hi, Quoting Junio C Hamano : SZEDER Gábor writes: @@ -412,7 +412,7 @@ __git_refs_remotes () __git_remotes () { local i IFS=$'\n' d="$(__gitdir)" - test -d "$d/remotes" && ls -1 "$d/remotes" + test -d "$d/remotes" && ls -1 "$d/remotes" 2>/dev

Re: [PATCH] contrib/completion: suppress stderror in bash

2015-02-10 Thread SZEDER Gábor
Hi, Quoting Junio C Hamano : SZEDER Gábor writes: @@ -412,7 +412,7 @@ __git_refs_remotes () __git_remotes () { local i IFS=$'\n' d="$(__gitdir)" - test -d "$d/remotes" && ls -1 "$d/remotes" + test -d "$d/remotes" && ls -1 "$d/remotes" 2>/dev/null for i in $(git -

Re: [PATCH] contrib/completion: suppress stderror in bash

2015-02-10 Thread Junio C Hamano
SZEDER Gábor writes: >>> @@ -412,7 +412,7 @@ __git_refs_remotes () >>> __git_remotes () >>> { >>> local i IFS=$'\n' d="$(__gitdir)" >>> - test -d "$d/remotes" && ls -1 "$d/remotes" >>> + test -d "$d/remotes" && ls -1 "$d/remotes" 2>/dev/null >>> for i in $(git --git-dir="$d" config

Re: [PATCH] contrib/completion: suppress stderror in bash

2015-02-09 Thread SZEDER Gábor
Hi, Quoting Junio C Hamano : Matt Korostoff writes: diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 2fece98..72251cc 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -412,7 +412,7 @@ __gi

Re: [PATCH] contrib/completion: suppress stderror in bash completion of git remotes

2015-02-09 Thread Matt Korostoff
Thank you for your detailed reply Junio. I'll try to address your concerns individually, but let me also offer a general thought that this is probably a good use case to handle even if the root cause is solvable outside of git. That is to say, I would think we'd still want git autocompletion work

Re: [PATCH] contrib/completion: suppress stderror in bash completion of git remotes

2015-02-09 Thread Junio C Hamano
Matt Korostoff writes: > In some system configurations there is a bug with the > __git_remotes function. Specifically, there is a problem > with line 415, `test -d "$d/remotes" && ls -1 "$d/remotes"`. > While `test -d` is meant to prevent listing the remotes > directory if it does not exist, in

Re: [PATCH] contrib/completion: suppress stderror in bash completion of git remotes

2015-02-09 Thread Matt Korostoff
Here are some screen shots demonstrating the issue I'm describing here: before this patch: https://cloud.githubusercontent.com/assets/1197335/6108333/1f3b10fa-b040-11e4-9164-3c7769dae110.gif after this patch: https://cloud.githubusercontent.com/assets/1197335/6108340/3878cad0-b040-11e4-9994-dcd5c

[PATCH] contrib/completion: suppress stderror in bash completion of git remotes

2015-02-09 Thread Matt Korostoff
In some system configurations there is a bug with the __git_remotes function. Specifically, there is a problem with line 415, `test -d "$d/remotes" && ls -1 "$d/remotes"`. While `test -d` is meant to prevent listing the remotes directory if it does not exist, in some system, `ls` will run regardle