Re: [PATCH] connect.c: handle errors from split_cmdline

2017-04-19 Thread Ævar Arnfjörð Bjarmason
On Mon, Apr 17, 2017 at 2:54 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> On Tue, Apr 11, 2017 at 12:54 PM, Jeff King wrote: >>> On Tue, Apr 11, 2017 at 11:27:57AM +0200, Ævar Arnfjörð Bjarmason wrote: >>> Junio: If you're not in some rush to pick this up I'll take this,

Re: [PATCH] connect.c: handle errors from split_cmdline

2017-04-16 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Tue, Apr 11, 2017 at 12:54 PM, Jeff King wrote: >> On Tue, Apr 11, 2017 at 11:27:57AM +0200, Ævar Arnfjörð Bjarmason wrote: >> >>> Junio: If you're not in some rush to pick this up I'll take this, fix >>> up a bunch of other bugs & tests failures on odd --roo

Re: [PATCH] connect.c: handle errors from split_cmdline

2017-04-16 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> That's fine by me. We may want to pick up the segfault one separately >> (though I don't think it's security-interesting). > > Up to you, but in case it's less work for you & Junio I already have > it in my branch of fallout from this series/discussion, so if it

Re: [PATCH] connect.c: handle errors from split_cmdline

2017-04-11 Thread Ævar Arnfjörð Bjarmason
On Tue, Apr 11, 2017 at 12:54 PM, Jeff King wrote: > On Tue, Apr 11, 2017 at 11:27:57AM +0200, Ævar Arnfjörð Bjarmason wrote: > >> Junio: If you're not in some rush to pick this up I'll take this, fix >> up a bunch of other bugs & tests failures on odd --root directories >> and submit this and Jef

Re: [PATCH] connect.c: handle errors from split_cmdline

2017-04-11 Thread Jeff King
On Tue, Apr 11, 2017 at 11:27:57AM +0200, Ævar Arnfjörð Bjarmason wrote: > Junio: If you're not in some rush to pick this up I'll take this, fix > up a bunch of other bugs & tests failures on odd --root directories > and submit this and Jeff's \r patch (after adding tests etc) along > with it. Th

Re: [PATCH] connect.c: handle errors from split_cmdline

2017-04-11 Thread Ævar Arnfjörð Bjarmason
g via the > results of basename(), but there isn't. There is a minor memory leak, > but it's best squashed into my original patch, like so: > > -- >8 -- > Subject: [PATCH] connect.c: handle errors from split_cmdline > > Commit e9d9a8a4d (connect: handle putty/plin

Re: [PATCH] connect.c: handle errors from split_cmdline

2017-04-10 Thread Jeff King
'll send another patch in a > minute, but I wanted to get this out in case you were working on it, > too. Actually, nevermind. I thought there was an issue with freeing via the results of basename(), but there isn't. There is a minor memory leak, but it's best squashed int

[PATCH] connect.c: handle errors from split_cmdline

2017-04-10 Thread Jeff King
tation fault > not ok 45 - single quoted plink.exe in GIT_SSH_COMMAND Here's a fix for that one. I think there are a few other memory irregularities in that function, too. I'll send another patch in a minute, but I wanted to get this out in case you were working on it, too. -- >8 --