Re: [PATCH] completion: zsh: improve bash script loading

2013-05-29 Thread Junio C Hamano
Felipe Contreras writes: >> Has this changed since 0a04e187e669 (completion: zsh: improve bash >> script loading, 2013-05-24) which I have on 'pu'? > > Other than this change, nope. > >> If not, I can do this locally to save a roundtrip, if you want. > > Great, let's do that. Done. The diff fro

Re: [PATCH] completion: zsh: improve bash script loading

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 12:49 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Wed, May 29, 2013 at 1:17 AM, Johannes Sixt wrote: >>> Am 5/29/2013 5:24, schrieb Felipe Contreras: +if [ -z "$script" ]; then + local -a locations + locations=( + '

Re: [PATCH] completion: zsh: improve bash script loading

2013-05-29 Thread Junio C Hamano
Felipe Contreras writes: > On Wed, May 29, 2013 at 1:17 AM, Johannes Sixt wrote: >> Am 5/29/2013 5:24, schrieb Felipe Contreras: >>> +if [ -z "$script" ]; then >>> + local -a locations >>> + locations=( >>> + '/etc/bash_completion.d/git' # fedora, old debian >>> +

Re: [PATCH] completion: zsh: improve bash script loading

2013-05-28 Thread Felipe Contreras
On Wed, May 29, 2013 at 1:17 AM, Johannes Sixt wrote: > Am 5/29/2013 5:24, schrieb Felipe Contreras: >> +if [ -z "$script" ]; then >> + local -a locations >> + locations=( >> + '/etc/bash_completion.d/git' # fedora, old debian >> + '/usr/share/bash-completion/comple

Re: [PATCH] completion: zsh: improve bash script loading

2013-05-28 Thread Johannes Sixt
Am 5/29/2013 5:24, schrieb Felipe Contreras: > +if [ -z "$script" ]; then > + local -a locations > + locations=( > + '/etc/bash_completion.d/git' # fedora, old debian > + '/usr/share/bash-completion/completions/git' # arch, ubuntu, > new debian > + '/usr

[PATCH] completion: zsh: improve bash script loading

2013-05-28 Thread Felipe Contreras
It's better to check in multiple locations, so the user doesn't have to. And update the documentation. Signed-off-by: Felipe Contreras --- contrib/completion/git-completion.zsh | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/contrib/completion/git

[PATCH] completion: zsh: improve bash script loading

2013-05-24 Thread Felipe Contreras
It's better to check in multiple locations, so the user doesn't have to. And update the documentation. Signed-off-by: Felipe Contreras --- contrib/completion/git-completion.zsh | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/contrib/completion/git