Re: [PATCH] commit.c:record_author_date() use skip_prefix() instead of starts_with()

2014-03-03 Thread Eric Sunshine
On Mon, Mar 3, 2014 at 1:40 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >>> -if (!starts_with(buf, "author ")) { >>> +if (!skip_prefix(buf, "author ")) { >> >> If this is the only change, there is not much point, is there? How does >> this help? Perhaps there

Re: [PATCH] commit.c:record_author_date() use skip_prefix() instead of starts_with()

2014-03-03 Thread Junio C Hamano
Michael Haggerty writes: >> -if (!starts_with(buf, "author ")) { >> +if (!skip_prefix(buf, "author ")) { > > If this is the only change, there is not much point, is there? How does > this help? Perhaps there is some way to take advantage of the > difference between start

Re: [PATCH] commit.c:record_author_date() use skip_prefix() instead of starts_with()

2014-03-03 Thread Michael Haggerty
The format of this email is wrong. The non-commit-message notes should come between the "---" line (<- note, there are three minus signs here) and the patch itself. On 03/01/2014 08:48 PM, Tanay Abhra wrote: > Signed-off-by: Tanay Abhra > --- > commit.c |2 +- > 1 file changed, 1 insertion(

[PATCH] commit.c:record_author_date() use skip_prefix() instead of starts_with()

2014-03-01 Thread Tanay Abhra
Signed-off-by: Tanay Abhra --- commit.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commit.c b/commit.c index 6bf4fe0..c954ecb 100644 --- a/commit.c +++ b/commit.c @@ -566,7 +566,7 @@ static void record_author_date(struct author_date_slab *author_date, bu