Re: [PATCH] commit-graph: normalize commit-graph filenames

2019-06-17 Thread Derrick Stolee
On 6/17/2019 11:02 AM, Derrick Stolee wrote: > - strbuf_setlen(&path, dirnamelen); > - strbuf_addstr(&path, de->d_name); > + char *filename = get_split_graph_filename(path.buf, de->d_name); Please ignore this patch for now, as this line is incredibly stupid and

[PATCH] commit-graph: normalize commit-graph filenames

2019-06-17 Thread Derrick Stolee
When writing commit-graph files, we append path data to an object directory, which may be specified by the user via the '--object-dir' option. If the user supplies a trailing slash, or some other alternative path format, the resulting path may be usable for writing to the correct location. However,