Re: [PATCH] commit: reword --author error message

2015-01-16 Thread Junio C Hamano
Eric Sunshine writes: > On Fri, Jan 16, 2015 at 1:35 PM, Junio C Hamano wrote: >> "Philip Oakley" writes: >> >>> die(_("--author '%s': not 'Name ', nor matches any existing >>> author")); >> >> Sounds good. Thanks. > > To further bikeshed (particularly if "nor" is in the mix): > > neit

Re: [PATCH] commit: reword --author error message

2015-01-16 Thread Eric Sunshine
On Fri, Jan 16, 2015 at 1:35 PM, Junio C Hamano wrote: > "Philip Oakley" writes: > >> die(_("--author '%s': not 'Name ', nor matches any existing >> author")); > > Sounds good. Thanks. To further bikeshed (particularly if "nor" is in the mix): neither 'Name ' nor a match for an existin

Re: [PATCH] commit: reword --author error message

2015-01-16 Thread Junio C Hamano
"Philip Oakley" writes: > die(_("--author '%s': not 'Name ', nor matches any existing > author")); Sounds good. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majo

Re: [PATCH] commit: reword --author error message

2015-01-16 Thread Philip Oakley
From: "Junio C Hamano" Jeff King writes: On Thu, Jan 15, 2015 at 09:48:26AM -0800, Junio C Hamano wrote: > Rename the error message to make it clearer that the failure has > two > reasons in this case: > "Bad --author parameter '%s': neither completely wellformed nor > part of > an exist

Re: [PATCH] commit: reword --author error message

2015-01-16 Thread Junio C Hamano
Jeff King writes: > On Thu, Jan 15, 2015 at 09:48:26AM -0800, Junio C Hamano wrote: > >> > Rename the error message to make it clearer that the failure has two >> > reasons in this case: >> > "Bad --author parameter '%s': neither completely wellformed nor part of >> > an existing one" >> >> You

Re: [PATCH] commit: reword --author error message

2015-01-16 Thread Jeff King
On Thu, Jan 15, 2015 at 09:48:26AM -0800, Junio C Hamano wrote: > > Rename the error message to make it clearer that the failure has two > > reasons in this case: > > "Bad --author parameter '%s': neither completely wellformed nor part of > > an existing one" > > You are trying to help a user who

Re: [PATCH] commit: reword --author error message

2015-01-15 Thread Junio C Hamano
Michael J Gruber writes: > If an --author argument is specified but does not contain a '>' then git tries > to find the argument within the exiting authors; and gives the error > message "No existing author found with '%s'" if there is no match. > > This is confusing for users who try to specify

Re: [PATCH] commit: reword --author error message

2015-01-15 Thread Michael J Gruber
Jeff King schrieb am 15.01.2015 um 15:31: > On Thu, Jan 15, 2015 at 03:23:08PM +0100, Michael J Gruber wrote: > >> If an --author argument is specified but does not contain a '>' then git >> tries >> to find the argument within the exiting authors; and gives the error >> message "No existing auth

Re: [PATCH] commit: reword --author error message

2015-01-15 Thread Jeff King
On Thu, Jan 15, 2015 at 03:23:08PM +0100, Michael J Gruber wrote: > If an --author argument is specified but does not contain a '>' then git tries > to find the argument within the exiting authors; and gives the error > message "No existing author found with '%s'" if there is no match. > > This i

Re: [PATCH] commit: reword --author error message

2015-01-15 Thread Michael J Gruber
Michael J Gruber schrieb am 15.01.2015 um 15:23: > If an --author argument is specified but does not contain a '>' then git tries > to find the argument within the exiting authors; and gives the error > message "No existing author found with '%s'" if there is no match. Oh well, I'm bracing already

[PATCH] commit: reword --author error message

2015-01-15 Thread Michael J Gruber
If an --author argument is specified but does not contain a '>' then git tries to find the argument within the exiting authors; and gives the error message "No existing author found with '%s'" if there is no match. This is confusing for users who try to specify a valid complete author name. Renam