Jens Lehmann writes:
> But submodule.mod.path should only be set in .gitmodules, not in
> $GIT_DIR/config. Did you just remove the ignore setting from
> .gitmodules or the path too?
Without that in $GIT_DIR/config, how would path<->name mapping
correctly work???
Confused...
--
To unsubscribe fr
Am 24.09.2012 21:59, schrieb Orgad Shaneh:
> On Mon, Sep 24, 2012 at 9:56 PM, Jens Lehmann wrote:
>> Am 24.09.2012 21:16, schrieb Orgad Shaneh:
>>> On Mon, Sep 24, 2012 at 9:06 PM, Junio C Hamano wrote:
Orgad Shaneh writes:
> That is not correct. git-config is ignored as well for c
On Mon, Sep 24, 2012 at 9:56 PM, Jens Lehmann wrote:
> Am 24.09.2012 21:16, schrieb Orgad Shaneh:
>> On Mon, Sep 24, 2012 at 9:06 PM, Junio C Hamano wrote:
>>> Orgad Shaneh writes:
>>>
That is not correct. git-config is ignored as well for commit.
>>>
>>> What do you mean? As far as I can
Am 24.09.2012 21:16, schrieb Orgad Shaneh:
> On Mon, Sep 24, 2012 at 9:06 PM, Junio C Hamano wrote:
>> Orgad Shaneh writes:
>>
>>> That is not correct. git-config is ignored as well for commit.
>>
>> What do you mean? As far as I can tell, if you have
>>
>> [submodule "var"]
>> path
On Mon, Sep 24, 2012 at 9:06 PM, Junio C Hamano wrote:
> Orgad Shaneh writes:
>
>> That is not correct. git-config is ignored as well for commit.
>
> What do you mean? As far as I can tell, if you have
>
> [submodule "var"]
> path = var
> ignore = dirty
>
> in $GIT_DIR/config
Orgad Shaneh writes:
> That is not correct. git-config is ignored as well for commit.
What do you mean? As far as I can tell, if you have
[submodule "var"]
path = var
ignore = dirty
in $GIT_DIR/config, a work-tree-dirty submodule "var" is not
reported by "git status" and "
On Mon, Sep 24, 2012 at 8:34 PM, Junio C Hamano wrote:
>
> Jens Lehmann writes:
>
> > Am 24.09.2012 18:27, schrieb Junio C Hamano:
> >> Junio C Hamano writes:
> >>> In any case, the log message I suggested in the review needs to be
> >>> updated in the reroll to make it clear that this is about
Jens Lehmann writes:
> Am 24.09.2012 18:27, schrieb Junio C Hamano:
>> Junio C Hamano writes:
>>> In any case, the log message I suggested in the review needs to be
>>> updated in the reroll to make it clear that this is about reading
>>> from .gitmodules, not "configuration". AFAICS, gitmodule
Am 24.09.2012 18:27, schrieb Junio C Hamano:
> Junio C Hamano writes:
>> In any case, the log message I suggested in the review needs to be
>> updated in the reroll to make it clear that this is about reading
>> from .gitmodules, not "configuration". AFAICS, gitmodule_config()
>> does not even re
Junio C Hamano writes:
> Jens Lehmann writes:
>
>>> Jens, what do you think? I see no reason for anybody other than
>>> "submodule init" to call gitmodules_config() that reads from the
>>> in-tree .gitmodules file.
>>
>> I think the copying on init is not what we should do here because
>> it se
Jens Lehmann writes:
>> Jens, what do you think? I see no reason for anybody other than
>> "submodule init" to call gitmodules_config() that reads from the
>> in-tree .gitmodules file.
>
> I think the copying on init is not what we should do here because
> it sets the user's customization to wha
Am 23.09.2012 10:37, schrieb Junio C Hamano:
> I see Jens added with 302ad7a (Submodules: Use "ignore" settings
> from .gitmodules too for diff and status, 2010-08-06) the call to
> gitmodules_config() to "git status" and "git diff" family, but I
> suspect that was a huge mistake. Once a submodule
Orgad Shaneh writes:
> As reported on the mailing list[1], ignore submodule config is not
> respected on commit.
>
> [1]
> http://git.661346.n2.nabble.com/submodule-ignore-is-not-respected-on-commit-td7539238.html
>
> Signed-off-by: Orgad Shaneh
> ---
Thanks.
Please do not force people to go
As reported on the mailing list[1], ignore submodule config is not
respected on commit.
[1]
http://git.661346.n2.nabble.com/submodule-ignore-is-not-respected-on-commit-td7539238.html
Signed-off-by: Orgad Shaneh
---
builtin/commit.c |1 +
1 file changed, 1 insertion(+)
diff --git a/builtin
14 matches
Mail list logo
