Re: [PATCH] credential doc: make multiple-helper behavior more prominent (Re: [PATCH] clone: handle empty config values in -c)

2017-05-01 Thread Jeff King
On Mon, May 01, 2017 at 05:30:10PM -0700, Jonathan Nieder wrote: > > @@ -162,6 +152,16 @@ helper:: > > shell (so, for example, setting this to `foo --option=bar` will execute > > `git credential-foo --option=bar` via the shell. See the manual of > > specific helpers for examples of the

Re: [PATCH] credential doc: make multiple-helper behavior more prominent (Re: [PATCH] clone: handle empty config values in -c)

2017-05-01 Thread Jeff King
On Mon, May 01, 2017 at 05:21:14PM -0700, Jonathan Nieder wrote: > Subject: credential doc: make multiple-helper behavior more prominent > > Git's configuration system works by reading multiple configuration > files in order, from general to specific: > > - first, the system configuration /etc/

Re: [PATCH] clone: handle empty config values in -c

2017-05-01 Thread Jeff King
On Mon, May 01, 2017 at 05:05:15PM -0700, Jonathan Nieder wrote: > "git clone --config" uses the following incantation to add an item to > a config file, instead of replacing an existing value: > > git_config_set_multivar_gently(key, value, "^$", 0) > > As long as no existing value matches

Re: [PATCH] credential doc: make multiple-helper behavior more prominent (Re: [PATCH] clone: handle empty config values in -c)

2017-05-01 Thread Jonathan Nieder
Starting out the reviews: Jonathan Nieder wrote: [...] > configuration item to empty before giving it a new value. This is > already documented by the documentation is hard to find --- ^^ s/by/but/ Sorry for the confusion. [...] > +++ b/Documentation/gitcredentials.txt [..

Re: [PATCH] credential doc: make multiple-helper behavior more prominent (Re: [PATCH] clone: handle empty config values in -c)

2017-05-01 Thread Brandon Williams
On 05/01, Jonathan Nieder wrote: > Subject: credential doc: make multiple-helper behavior more prominent > > Git's configuration system works by reading multiple configuration > files in order, from general to specific: > > - first, the system configuration /etc/gitconfig > - then the user's co

[PATCH] credential doc: make multiple-helper behavior more prominent (Re: [PATCH] clone: handle empty config values in -c)

2017-05-01 Thread Jonathan Nieder
Subject: credential doc: make multiple-helper behavior more prominent Git's configuration system works by reading multiple configuration files in order, from general to specific: - first, the system configuration /etc/gitconfig - then the user's configuration (~/.gitconfig or ~/.config/git/conf

Re: [PATCH] clone: handle empty config values in -c

2017-05-01 Thread Brandon Williams
On 05/01, Jonathan Nieder wrote: > "git clone --config" uses the following incantation to add an item to > a config file, instead of replacing an existing value: > > git_config_set_multivar_gently(key, value, "^$", 0) > > As long as no existing value matches the regex ^$, that works as > in

[PATCH] clone: handle empty config values in -c

2017-05-01 Thread Jonathan Nieder
"git clone --config" uses the following incantation to add an item to a config file, instead of replacing an existing value: git_config_set_multivar_gently(key, value, "^$", 0) As long as no existing value matches the regex ^$, that works as intended and adds to the config. When a value