Re: [PATCH] clone: fix colliding file detection on APFS

2018-11-20 Thread Duy Nguyen
On Tue, Nov 20, 2018 at 8:35 PM Carlo Arenas wrote: > IMHO it would be ideal if test would be enabled/validated for windows > (native, not only cygwin) as it might even work without the override > and if we are to see conflicts, that is probably where most users with > file insensitive filesystems

Re: [PATCH] clone: fix colliding file detection on APFS

2018-11-20 Thread Carlo Arenas
Tested-by: Carlo Marcelo Arenas Belón in macOS 10.14.1 with APFS in Linux using VFAT (for the lulz) IMHO it would be ideal if test would be enabled/validated for windows (native, not only cygwin) as it might even work without the override and if we are to see conflicts, that is probably where mo

Re: [PATCH] clone: fix colliding file detection on APFS

2018-11-20 Thread Ramsay Jones
On 20/11/2018 16:28, Nguyễn Thái Ngọc Duy wrote: > Commit b878579ae7 (clone: report duplicate entries on case-insensitive > filesystems - 2018-08-17) adds a warning to user when cloning a repo > with case-sensitive file names on a case-insensitive file system. The > "find duplicate file" check w

[PATCH] clone: fix colliding file detection on APFS

2018-11-20 Thread Nguyễn Thái Ngọc Duy
Commit b878579ae7 (clone: report duplicate entries on case-insensitive filesystems - 2018-08-17) adds a warning to user when cloning a repo with case-sensitive file names on a case-insensitive file system. The "find duplicate file" check was doing by comparing inode number (and only fall back to fs