Re: [PATCH] ci: make sure we build Git parallel

2019-02-08 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Thu, 7 Feb 2019, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> >> >> >> +# Clear MAKEFLAGS that may come from the outside world. >> >> +export MAKEFLAGS= >> >> + >> ... >> I meant to clear it at the beginning, where I "export MAKEF

Re: [PATCH] ci: make sure we build Git parallel

2019-02-08 Thread Johannes Schindelin
Hi Junio, On Thu, 7 Feb 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> > >> +# Clear MAKEFLAGS that may come from the outside world. > >> +export MAKEFLAGS= > >> + > >> # Set 'exit on error' for all CI scripts to let the caller know that > >> # something went wrong. > >>

Re: [PATCH] ci: make sure we build Git parallel

2019-02-07 Thread Junio C Hamano
Johannes Schindelin writes: >> >> +# Clear MAKEFLAGS that may come from the outside world. >> +export MAKEFLAGS= >> + >> # Set 'exit on error' for all CI scripts to let the caller know that >> # something went wrong. >> # Set tracing executed commands, primarily setting environment variables

Re: [PATCH] ci: make sure we build Git parallel

2019-02-07 Thread Johannes Schindelin
Hi Junio, On Thu, 7 Feb 2019, Junio C Hamano wrote: > Junio C Hamano writes: > > > Wouldn't all other hits of "MAKEFLAGS=" in ci/lib.sh also want the > > same treatment, though? We know that "if travis to this, otherwise > > if Asure, do that" is the first block to muck with MAKEFLAGS in the >

Re: [PATCH] ci: make sure we build Git parallel

2019-02-07 Thread Junio C Hamano
Junio C Hamano writes: > Wouldn't all other hits of "MAKEFLAGS=" in ci/lib.sh also want the > same treatment, though? We know that "if travis to this, otherwise > if Asure, do that" is the first block to muck with MAKEFLAGS in the > script, but a new assignment before that block can be added in

Re: [PATCH] ci: make sure we build Git parallel

2019-02-07 Thread Junio C Hamano
Junio C Hamano writes: > SZEDER Gábor writes: > >> Append to MAKEFLAGS when setting the compiler to use, to ensure that >> the number of parallel jobs to use is preserved. >> >> Signed-off-by: SZEDER Gábor >> --- >> ci/lib.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff

Re: [PATCH] ci: make sure we build Git parallel

2019-02-07 Thread Junio C Hamano
SZEDER Gábor writes: > Append to MAKEFLAGS when setting the compiler to use, to ensure that > the number of parallel jobs to use is preserved. > > Signed-off-by: SZEDER Gábor > --- > ci/lib.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ci/lib.sh b/ci/lib.sh > index

[PATCH] ci: make sure we build Git parallel

2019-02-07 Thread SZEDER Gábor
Commit 2c8921db2b (travis-ci: build with the right compiler, 2019-01-17) started to use MAKEFLAGS to specify which compiler to use to build Git. A bit later, and in a different topic branch commit eaa62291ff (ci: inherit --jobs via MAKEFLAGS in run-build-and-tests, 2019-01-27) started to use MAKEF