Re: [PATCH] cherry-pick -x: improve handling of one-liner commit messages

2013-03-29 Thread Junio C Hamano
Miklos Vajna writes: > On Fri, Mar 29, 2013 at 10:41:17AM -0700, Brandon Casey > wrote: > >> > I think this is part of the bc/append-signed-off-by topic that is >> > about to graduate to 'master'; more specifically, b971e04f54e7 >> > (sequencer.c: always separate "(cherry picked from" from comm

Re: [PATCH] cherry-pick -x: improve handling of one-liner commit messages

2013-03-29 Thread Miklos Vajna
Hi, On Fri, Mar 29, 2013 at 10:41:17AM -0700, Brandon Casey wrote: > > Sign-off? Indeed, I forgot about it, my bad. > > I think this is part of the bc/append-signed-off-by topic that is > > about to graduate to 'master'; more specifically, b971e04f54e7 > > (sequencer.c: always separate "(cherr

Re: [PATCH] cherry-pick -x: improve handling of one-liner commit messages

2013-03-29 Thread Brandon Casey
On Fri, Mar 29, 2013 at 10:23 AM, Junio C Hamano wrote: > Miklos Vajna writes: > >> git cherry-pick -x normally just appends the "cherry picked from commit" >> line at the end of the message, which is fine. However, in case the >> original commit message had only one line, first append a newline,

Re: [PATCH] cherry-pick -x: improve handling of one-liner commit messages

2013-03-29 Thread Junio C Hamano
Miklos Vajna writes: > git cherry-pick -x normally just appends the "cherry picked from commit" > line at the end of the message, which is fine. However, in case the > original commit message had only one line, first append a newline, > otherwise the second line won't be empty, which is against >

[PATCH] cherry-pick -x: improve handling of one-liner commit messages

2013-03-29 Thread Miklos Vajna
git cherry-pick -x normally just appends the "cherry picked from commit" line at the end of the message, which is fine. However, in case the original commit message had only one line, first append a newline, otherwise the second line won't be empty, which is against recommendations. --- sequencer.