Re: [PATCH] check-non-portable-shell: support Perl versions older than 5.10

2019-05-10 Thread Eric Sunshine
On Thu, May 9, 2019 at 8:33 AM Ævar Arnfjörð Bjarmason wrote: > On Thu, May 09 2019, Eric Sunshine wrote: > > Although this implementation is well supported in reasonably modern Perl > > versions (5.10 and later), it fails in a couple ways with older versions > > (such as Perl 5.8 shipped with anc

Re: [PATCH] check-non-portable-shell: support Perl versions older than 5.10

2019-05-09 Thread Ævar Arnfjörð Bjarmason
On Thu, May 09 2019, Eric Sunshine wrote: > For thoroughness when checking for one-shot environment variable > assignments at shell function call sites, check-non-portable-shell > stitches together incomplete lines (those ending with backslash). This > allows it to correctly flag such undesirabl

[PATCH] check-non-portable-shell: support Perl versions older than 5.10

2019-05-09 Thread Eric Sunshine
For thoroughness when checking for one-shot environment variable assignments at shell function call sites, check-non-portable-shell stitches together incomplete lines (those ending with backslash). This allows it to correctly flag such undesirable usage even when the variable assignment and functio