Re: [PATCH] cache-tree.c: fix i-t-a check skipping directory updates sometimes

2016-07-06 Thread Junio C Hamano
Junio C Hamano writes: > Nguyễn Thái Ngọc Duy writes: > >> Fix it by making sure we only skip i-t-a entries when the entry in >> question is actual an index entry, not a directory. > > Aha. Good catch. > > However, this makes me wonder if subdir has only files all of which > are i-t-a. The re

Re: [PATCH] cache-tree.c: fix i-t-a check skipping directory updates sometimes

2016-07-06 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Commit 3cf773e (cache-tree: fix writing cache-tree when CE_REMOVE is > present - 2012-12-16) skips i-t-a entries when building trees objects > from the index. Unfortunately it may skip too much. > > The code in question checks if an entry is an i-t-a one, then no t

[PATCH] cache-tree.c: fix i-t-a check skipping directory updates sometimes

2016-07-04 Thread Nguyễn Thái Ngọc Duy
Commit 3cf773e (cache-tree: fix writing cache-tree when CE_REMOVE is present - 2012-12-16) skips i-t-a entries when building trees objects from the index. Unfortunately it may skip too much. The code in question checks if an entry is an i-t-a one, then no tree entry will be written. But it does no