Re: [PATCH] builtin/receive-pack.c: use parse_options API

2016-03-01 Thread Eric Sunshine
On Tue, Mar 1, 2016 at 12:57 PM, Matthieu Moy wrote: > Sidhant Sharma writes: >> Another thing I'd like to ask is when I prepare the next patch, should >> it be sent as reply in this thread, or as a new thread? > > No strict rule on that, but I usually use --in-reply-to on the root of > the threa

Re: [PATCH] builtin/receive-pack.c: use parse_options API

2016-03-01 Thread Matthieu Moy
Sidhant Sharma writes: >>> + if (argc > 1) >>> + usage_msg_opt(_("Too many arguments."), receive_pack_usage, >>> options); >>> + if (argc == 0) >>> + usage_msg_opt(_("You must specify a directory."), >>> receive_pack_usage, options); >> Before that, the loop was ensuring

Re: [PATCH] builtin/receive-pack.c: use parse_options API

2016-03-01 Thread Sidhant Sharma
> Hi, > > Thanks for your patch. > > "Sidhant Sharma [:tk]" writes: > >> This patch makes receive-pack use the parse_options API, > We usually avoid saying "this patch" and use imperative tone: talk to > your patch and give it orders like "Make receive-pack use the > parse_options API ...". Or ju

Re: [PATCH] builtin/receive-pack.c: use parse_options API

2016-03-01 Thread Matthieu Moy
Hi, Thanks for your patch. "Sidhant Sharma [:tk]" writes: > This patch makes receive-pack use the parse_options API, We usually avoid saying "this patch" and use imperative tone: talk to your patch and give it orders like "Make receive-pack use the parse_options API ...". Or just skip that par

[PATCH] builtin/receive-pack.c: use parse_options API

2016-03-01 Thread Sidhant Sharma [:tk]
This patch makes receive-pack use the parse_options API, bringing it more in line with send-pack and push. Helped-by: Matthieu Moy Signed-off-by: Sidhant Sharma [:tk] --- builtin/receive-pack.c | 55 ++ 1 file changed, 24 insertions(+), 31 deletio