Re: [PATCH] builtin/receive-pack: dead initializer for retval in check_nonce

2018-10-21 Thread Junio C Hamano
Torsten Bögershausen writes: > Initializing a variable to "BAD" in the beginning can be a good thing > for two reasons: > - There is a complex if-elseif chain, which should set retval > in any case, this is at least what I expect taking a very quick look at the > code: > ... > # The second re

Re: [PATCH] builtin/receive-pack: dead initializer for retval in check_nonce

2018-10-21 Thread Carlo Arenas
On Sat, Oct 20, 2018 at 9:45 AM Torsten Bögershausen wrote: > > The motivation feels a little bit weak, at least to me. I have to admit, I was sitting on this patch for a while for the same reason but I should had made a more compelling commit message either way and will definitely fix that with

Re: [PATCH] builtin/receive-pack: dead initializer for retval in check_nonce

2018-10-20 Thread Torsten Bögershausen
On Sat, Oct 20, 2018 at 12:08:59AM -0700, Carlo Marcelo Arenas Belón wrote: > NONCE_BAD is explicitly set when needed with the fallback > instead as NONCE_SLOP > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > builtin/receive-pack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[PATCH] builtin/receive-pack: dead initializer for retval in check_nonce

2018-10-20 Thread Carlo Marcelo Arenas Belón
NONCE_BAD is explicitly set when needed with the fallback instead as NONCE_SLOP Signed-off-by: Carlo Marcelo Arenas Belón --- builtin/receive-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c index 95740f4f0e..ecce3d4043 10